- Sep 09, 2024
-
-
Saurabh Kumar authored
- The current make -j parallelization doesn't kill the remaining process when one of them errors out, the causes confusion if let's css/js is not building. - This PR also refractors the help target to use comment based generator which is more maintainable. - Update the node scripts to not require `collectstatic` during development, the runserver -> static server can find all the all files from packages and serve them on demand. - `make serve` now also installs python & node packages and builds the static_src if they are outdated. --------- Co-authored-by:
Fredrik Jonsson <frjo@xdeb.org>
-
- Aug 08, 2024
-
-
Saurabh Kumar authored
- Delete modal - Update status modal - update reviewer - Archive/unarchive modal and view/logic - Create reminder modal - update reminder block design - Add modal title component - Django messages as toast for htmx request - [x] update lead modal response - [x] meta term modal - [x] new project modal - [x] partner update modal - Adds new htmx based handler for django-message-framework and display them as toast Fixes #3391 Co-authored-by:
sandeepsajan0 <sandeepsajan0@gmail.com>
-
- Jul 29, 2024
-
-
Saurabh Kumar authored
There might be a better way to do in each of the test iteslf but consider this a temporary fix, right now test generate a huge number of files that are left as it is after the tests are finished. This PR updates the test file names to be more consistent and then deletes them based on generated file name pattern
-
- Jun 26, 2024
-
-
Fredrik Jonsson authored
-
- Mar 22, 2024
-
-
Fredrik Jonsson authored
-
- Feb 22, 2024
-
-
Fredrik Jonsson authored
Removes the "src" and "apply" sub directory levels resulting in a more flat directory structure for static assets. No changes in functionality should be a result of this. It is only to make it easier for developers to move around the code base.
-
- Jan 11, 2024
-
-
Saurabh Kumar authored
ruff is drop-in-replacement for black and some of deviations actually make some sense. Argueably they seems to be very good at what they do, while for us it's one less dependency to manage See https://docs.astral.sh/ruff/formatter/ to understand more
-
- Oct 20, 2023
-
-
Saurabh Kumar authored
- black - coverage - django-browser-reload - django-coverage-plugin - django-debug-toolbar - pytest-cov - pytest-split - pytest-xdist - reponses - ruff
-
- Sep 08, 2023
-
-
Saurabh Kumar authored
Easier way to check and fix formatting issues if don't want to go precommit hooks route
-
Saurabh Kumar authored
Add black and prettier check to lint
-
- Aug 11, 2023
-
-
Saurabh Kumar authored
- Add black, djhtml, prettier - Add precommit This PR add configurations for black, djhtml and prettier. - black is used for formatting python files - djhtml for formatting html files. Use `{# fmt: off #}` and `{# fmt: on #}` where needed. - prettier for formatting of sass,css,yml and js files Note: prettier picks up some of it's config from `.editorconfig`, so it's updated appropriately Formating of mardown files, minified or vendored js files are ignored. Formatting used off-the-self rules for better consistency with the community as large. The formatting is not applied to all the files as it will introduce a lot of merge conflict with current PRs, instead `pre-commit` config is provide which can be installed by `precommit install` locally. It will format only the modified files in the PR/commits. Once majority of the current active PRs are either rebased & formatted using precommit or merged, we can run the `make fmt` on the full repo and activate additional prettier and black checks in our lint rules. The modified sass files fixes the eslint error that would came up if we were to apply the prettier formatter on them. Fixes #3500
-
- Jun 15, 2023
-
-
Saurabh Kumar authored
Fixes #3430 - [x] Simplified code - [x] Use postgres FTS search - [x] Improve UX for filters - [x] Improve submission listing - [x] Add filter for submission date, OTF have asked about this. - [x] Add submission ID search, see https://github.com/HyphaApp/hypha/pull/3294 - [x]
🏃🏼 Make sure the batch actions are working - [x]🏃🏼 Permissions check for batch actions - [x] Ensure search index works after submissions is updated - [x] ~Integrate Django messages framework with htmx responses~ (Not needed) - [x] [Fix Polynomial regular expression used on uncontrolled data](https://github.com/HyphaApp/hypha/security/code-scanning/74 ) - [ ] make bulk update status working, currently it's hidden. --------- Co-authored-by:Fredrik Jonsson <frjo@xdeb.org>
-
- Mar 14, 2023
-
-
Saurabh Kumar authored
Run Django and docs preview server, and watch and compile frontend changes in parallel. This lets you quickly spin up and run everything in a single terminal.
-
- Feb 02, 2023
-
-
Fredrik Jonsson authored
-
- Jan 13, 2023
-
-
Saurabh Kumar authored
Fixes #3101 - Remove `make sort` and `make sort-fix` make targerts - Use `make lint` and `make lint-fix` instead. - Make use of GitHub Annotation to surface issues as annotations directly in the files changed, similar to CodeQL. - Move stuff from `setup.cfg` to `pyproject.toml` - Fixed the potentially buggy code. Each of the fix types is in individual commits.
-
- Dec 15, 2022
-
-
Saurabh Kumar authored
Fixes #3079
-
- Aug 30, 2022
-
-
Saurabh Kumar authored
Break test target into smaller targets
-
- Aug 28, 2022
-
-
Saurabh Kumar authored
- Add “make test” command to lint, test and report coverage - Add pytest runner - It automatically set up to use the correct Django settings module - Runs tests on all the available CPU, I was able to run all the test in total=~30sec using “make test” command. - It provides a cleaner error report, compared to DjangoTestRunner - Coverage - Displayed the report on the terminal after the test finish - Disable reporting of coverage for test and migration files - Enable coverage reporting for the template files - “make test” generates HTML reports to quickly check the coverage of each file
-
- Jan 18, 2021
-
-
Fredrik Jonsson authored
-
- Feb 25, 2020
-
-
Todd Dembrey authored
- Add missing PHONY definition for `help` - Add `lint` command to run both isort and flake8 - Add `style` command to run flake8 - Rename `fix` to `sort-fix` to fix the isort errors - Remove exit code from `sort` as it hid errors and emits error codes anyway
-
- Feb 24, 2020
-
-
George Hickman authored
-
- Jul 22, 2019
-
-
Fredrik Jonsson authored
-
- Jul 19, 2019
-
-
George Hickman authored
-