Skip to content
Snippets Groups Projects
  1. Sep 09, 2024
    • Saurabh Kumar's avatar
      Update makefile, auto-help and better serve (#4109) · c20578f6
      Saurabh Kumar authored
      
      - The current make -j parallelization doesn't kill the remaining process
      when one of them errors out, the causes confusion if let's css/js is not
      building.
      
      - This PR also refractors the help target to use comment based generator
      which is more maintainable.
      
      - Update the node scripts to not require `collectstatic` during
      development, the runserver -> static server can find all the all files
      from packages and serve them on demand.
      - `make serve` now also installs python & node packages and builds the
      static_src if they are outdated.
      
      ---------
      
      Co-authored-by: default avatarFredrik Jonsson <frjo@xdeb.org>
      c20578f6
  2. Sep 04, 2024
  3. Sep 03, 2024
  4. Aug 28, 2024
    • Wes Appler's avatar
      Update htmx to 2.x (#4102) · 81e1245d
      Wes Appler authored
      Fixes #4094. 
      
      ~~For some reason, when combining other triggers with
      `revealed` the revealed trigger itself breaks while others remain fine.
      Swapping for the `intersect once` trigger resolved this but I'm not
      exactly sure why. Also not sure if moving forward for consistency we
      should use `intersect` instead of `revealed`. @theskumar any thoughts?~~
      
      Updated htmx from v1.9.12 -> v2.0.2 to fix the usage of multiple tags
      breaking `revealed`. Tested locally and there doesn't seem to be any
      major breaking changes.
  5. Aug 27, 2024
  6. Aug 26, 2024
  7. Aug 16, 2024
    • Saurabh Kumar's avatar
      Fix docs from being built (#4100) · 0b08aaaf
      Saurabh Kumar authored
      0b08aaaf
    • Wes Appler's avatar
      Make background color consistent across the app (#4059) · dff06c75
      Wes Appler authored
      The applicant dashboard (and various other views) used tailwind's
      `bg-light-grey` which seems inconsistent with the overall app and caused
      the menu to have a different standout color.
      
      I believe the grey background does add a nice contrast to things so I
      made that the system default. Open to making it all white, though.
      dff06c75
    • Wes Appler's avatar
      Fixed consent prompt always popping up when `Ok` is the only option (#4089) · 41c693d3
      Wes Appler authored
      Fixes #4088. 
      
      The logic that will reprompt the user if the cookie option
      changes was getting tripped as it was only checking for 1 button rather
      than 2 that exist when ack'ing.
      41c693d3
    • Wes Appler's avatar
      Implemented `Remember me` for passwordless login (#4064) · d1725f5a
      Wes Appler authored
      Fixes #4009. 
      
      Implements a session extension for the magic link by
      utilizing an extra `remember-me` URL param. Also adds a configuration
      option to extend the session age to `SESSION_COOKIE_AGE_LONG` when OAuth
      is utilized for the login.
      d1725f5a
    • Wes Appler's avatar
      Hide PII from external reviewers, along with private reviews (#4018) · aa73e2b8
      Wes Appler authored
      Fixes #3240. 
      
      Adds `HIDE_IDENTITY_FROM_REVIEWERS`config option to hide
      the identities of staff & applicants from external reviewers. This also
      hides reviews that don't have visibility set to `reviewer` from the
      sidebar as that seemed ore intuitive.
      
      There is also a fix here for the `Updated` field of the application
      where the original author will always be specified as the application
      editor even if someone else updated it. This is an edge case but will be
      helpful as we implement things like #3919.
      aa73e2b8
  8. Aug 15, 2024
  9. Aug 13, 2024
  10. Aug 09, 2024
  11. Aug 08, 2024
    • Frank Duncan's avatar
      Fix error in View All when no reviewer role image (#4068) · e7df1b44
      Frank Duncan authored
      Fixes #4067
      e7df1b44
    • Sandeep Chauhan's avatar
      Remove tasks from task list (#4040) · 40dedd44
      Sandeep Chauhan authored
      Fixes Manual task removal issue. 
      Two colors trash because of single user task and user group task.
      40dedd44
    • Saurabh Kumar's avatar
      Update modals to use htmx/alpine (#4053) · ef47125a
      Saurabh Kumar authored
      
      - Delete modal
      - Update status modal
      - update reviewer
      - Archive/unarchive modal and view/logic
      - Create reminder modal
      - update reminder block design
      - Add modal title component
      - Django messages as toast for htmx request
      - [x] update lead modal response
      - [x] meta term modal
      - [x] new project modal
      - [x] partner update modal
      - Adds new htmx based handler for django-message-framework and display
      them as toast
      
      Fixes #3391
      
      Co-authored-by: default avatarsandeepsajan0 <sandeepsajan0@gmail.com>
      ef47125a
    • Sandeep Chauhan's avatar
    • Wes Appler's avatar
      Speed & appearance improvements to the results page (#4043) · 2eeb7501
      Wes Appler authored
      
      Fixes #3941. 
      
      This makes some speed improvements to the results page
      along with fixes to the appearance of some currency values. Some of the
      biggest improvements come with the initial loading of the
      `/submissions/result/` with no filters/query params applied, the
      `.values()` for all submissions were being calculated twice. After some
      crude benchmarking with very large (OTF scale) datasets, it seems to be
      ~26% faster. Other improvements were just not loading fields that were
      irrelevant to the data presented.
      
      Testing of initial loading of `/submissions/result/` was as follows:
      
      **Unoptimized**
      
      | Trial | SQL Time (ms) | SQL Queries |
      | ----- | ------------- | ----------- |
      | 1     | 3715.86       | 32          | 
      | 2     | 4429.34       | 33          |
      | 3     | 4449.12       | 33          |
      | 4     | 4615.63       | 33          |
      | 5     | 4852.89       | 33          |
      
      *Average SQL Time:* 4412.57
      
      **Optimizied**
      
      | Trial | SQL Time (ms) | SQL Queries |
      | ----- | ------------- | ----------- |
      | 1     | 3006.05       | 32          |
      | 2     | 3448.47       | 32          |
      | 3     | 3315.12       | 32          | 
      | 4     | 3317.39       | 32          |
      | 5     | 3137.71       | 32          |
      
      *Average SQL Time:* 3244.95
      
      Hopefully this leads to less crashing on production. If you see anything
      else that can be optimized let me know!
      
      ## Test Steps
      <!-- 
      If step does not require manual testing, skip/remove this section.
      
      Give a brief overview of the steps required for a user/dev to test this
      contribution. Important things to include:
       - Required user roles for where necessary (ie. "As a Staff Admin...")
      - Clear & validatable expected results (ie. "Confirm the submit button
      is now not clickable")
      - Language that can be understood by non-technical testers if being
      tested by users
      -->
      
       - Ensure the `/submissions/result/` view... 
           - [ ] is snappier and doesn't crash on load
           - [ ] has proper decimal amounts & currency symbols
      
      ---------
      
      Co-authored-by: default avatarFredrik Jonsson <frjo@xdeb.org>
      2eeb7501
    • Saurabh Kumar's avatar
      Fix primary nav background color on gray background (#4079) · 531fff93
      Saurabh Kumar authored
      On the desktop view, esp. for applicant the top nav shows a white
      background.
      
      This fixes and applies the nav bg only when the mobile menu is active
      531fff93
  12. Aug 06, 2024
  13. Aug 02, 2024
  14. Jul 31, 2024
  15. Jul 29, 2024
    • Saurabh Kumar's avatar
      Clean test files from disk after test are finished (#4070) · b599748d
      Saurabh Kumar authored
      There might be a better way to do in each of the test iteslf
      but consider this a temporary fix, right now test generate a huge number
      of files that are left as it is after the tests are finished.
      
      This PR updates the test file names to be more consistent and then
      deletes them based on generated file name pattern
      b599748d
  16. Jul 23, 2024
  17. Jul 18, 2024
  18. Jul 17, 2024
Loading