Skip to content
Snippets Groups Projects
  1. Sep 09, 2024
    • Saurabh Kumar's avatar
      Update makefile, auto-help and better serve (#4109) · c20578f6
      Saurabh Kumar authored
      
      - The current make -j parallelization doesn't kill the remaining process
      when one of them errors out, the causes confusion if let's css/js is not
      building.
      
      - This PR also refractors the help target to use comment based generator
      which is more maintainable.
      
      - Update the node scripts to not require `collectstatic` during
      development, the runserver -> static server can find all the all files
      from packages and serve them on demand.
      - `make serve` now also installs python & node packages and builds the
      static_src if they are outdated.
      
      ---------
      
      Co-authored-by: default avatarFredrik Jonsson <frjo@xdeb.org>
      c20578f6
  2. Aug 08, 2024
    • Saurabh Kumar's avatar
      Update modals to use htmx/alpine (#4053) · ef47125a
      Saurabh Kumar authored
      
      - Delete modal
      - Update status modal
      - update reviewer
      - Archive/unarchive modal and view/logic
      - Create reminder modal
      - update reminder block design
      - Add modal title component
      - Django messages as toast for htmx request
      - [x] update lead modal response
      - [x] meta term modal
      - [x] new project modal
      - [x] partner update modal
      - Adds new htmx based handler for django-message-framework and display
      them as toast
      
      Fixes #3391
      
      Co-authored-by: default avatarsandeepsajan0 <sandeepsajan0@gmail.com>
      ef47125a
  3. Jul 29, 2024
    • Saurabh Kumar's avatar
      Clean test files from disk after test are finished (#4070) · b599748d
      Saurabh Kumar authored
      There might be a better way to do in each of the test iteslf
      but consider this a temporary fix, right now test generate a huge number
      of files that are left as it is after the tests are finished.
      
      This PR updates the test file names to be more consistent and then
      deletes them based on generated file name pattern
      b599748d
  4. Jun 26, 2024
  5. Mar 22, 2024
  6. Feb 22, 2024
    • Fredrik Jonsson's avatar
      Flatten static src dirs (#3781) · 7674ce5a
      Fredrik Jonsson authored
      Removes the "src" and "apply" sub directory levels resulting in a more
      flat directory structure for static assets.
      
      No changes in functionality should be a result of this. It is only to
      make it easier for developers to move around the code base.
      7674ce5a
  7. Jan 11, 2024
  8. Oct 20, 2023
  9. Sep 08, 2023
  10. Aug 11, 2023
    • Saurabh Kumar's avatar
      Add pre-commit with black,prettier and djhtml (#3502) · 4ce14204
      Saurabh Kumar authored
      - Add black, djhtml, prettier
      - Add precommit
      
      
      This PR add configurations for black, djhtml and prettier.
      
      - black is used for formatting python files
      - djhtml for formatting html files. Use `{# fmt: off #}` and `{# fmt: on
      #}` where needed.
      - prettier for formatting of sass,css,yml and js files
      
      Note: prettier picks up some of it's config from `.editorconfig`, so
      it's updated appropriately
      
      Formating of mardown files, minified or vendored js files are ignored.
      
      Formatting used off-the-self rules for better consistency with the
      community as large.
      
      The formatting is not applied to all the files as it will introduce a
      lot of merge conflict with
      current PRs, instead `pre-commit` config is provide which can be
      installed by `precommit install`
      locally. It will format only the modified files in the PR/commits. 
      
      Once majority of the current active PRs are either rebased & formatted
      using precommit or merged, we can
      run the `make fmt` on the full repo and activate additional prettier and
      black checks in our lint rules.
      
      The modified sass files fixes the eslint error that would came up if we
      were to apply the prettier formatter on them.
      
      Fixes #3500
      4ce14204
  11. Jun 15, 2023
  12. Mar 14, 2023
  13. Feb 02, 2023
  14. Jan 13, 2023
    • Saurabh Kumar's avatar
      Replace flake8 & isort with ruff (#3103) · 5eab4ac4
      Saurabh Kumar authored
      Fixes #3101
      
      - Remove `make sort` and `make sort-fix` make targerts
      - Use `make lint` and `make lint-fix` instead.
      - Make use of GitHub Annotation to surface issues as annotations
      directly in the files changed, similar to CodeQL.
      - Move stuff from `setup.cfg` to `pyproject.toml`
      - Fixed the potentially buggy code. Each of the fix types is in
      individual commits.
      5eab4ac4
  15. Dec 15, 2022
  16. Aug 30, 2022
  17. Aug 28, 2022
    • Saurabh Kumar's avatar
      Improve testing and development experience · 91a25396
      Saurabh Kumar authored
      - Add “make test” command to lint, test and report coverage
      - Add pytest runner 
        - It automatically set up to use the correct Django settings module
        - Runs tests on all the available CPU, I was able to run all the test in total=~30sec using “make test” command.
        - It provides a cleaner error report, compared to DjangoTestRunner
      - Coverage
        - Displayed the report on the terminal after the test finish
        - Disable reporting of coverage for test and migration files
        - Enable coverage reporting for the template files
        - “make test” generates HTML reports to quickly check the coverage of each file
      91a25396
  18. Jan 18, 2021
  19. Feb 25, 2020
    • Todd Dembrey's avatar
      Centralise linting commands in the makefile · 9d0ae152
      Todd Dembrey authored
      - Add missing PHONY definition for `help`
      - Add `lint` command to run both isort and flake8
      - Add `style` command to run flake8
      - Rename `fix` to `sort-fix` to fix the isort errors
      - Remove exit code from `sort` as it hid errors and emits error codes anyway
      9d0ae152
  20. Feb 24, 2020
  21. Jul 22, 2019
  22. Jul 19, 2019
Loading