Skip to content
Snippets Groups Projects
  1. Sep 08, 2023
  2. Aug 11, 2023
    • Saurabh Kumar's avatar
      Add pre-commit with black,prettier and djhtml (#3502) · 4ce14204
      Saurabh Kumar authored
      - Add black, djhtml, prettier
      - Add precommit
      
      
      This PR add configurations for black, djhtml and prettier.
      
      - black is used for formatting python files
      - djhtml for formatting html files. Use `{# fmt: off #}` and `{# fmt: on
      #}` where needed.
      - prettier for formatting of sass,css,yml and js files
      
      Note: prettier picks up some of it's config from `.editorconfig`, so
      it's updated appropriately
      
      Formating of mardown files, minified or vendored js files are ignored.
      
      Formatting used off-the-self rules for better consistency with the
      community as large.
      
      The formatting is not applied to all the files as it will introduce a
      lot of merge conflict with
      current PRs, instead `pre-commit` config is provide which can be
      installed by `precommit install`
      locally. It will format only the modified files in the PR/commits. 
      
      Once majority of the current active PRs are either rebased & formatted
      using precommit or merged, we can
      run the `make fmt` on the full repo and activate additional prettier and
      black checks in our lint rules.
      
      The modified sass files fixes the eslint error that would came up if we
      were to apply the prettier formatter on them.
      
      Fixes #3500
      Unverified
      4ce14204
  3. Jun 15, 2023
  4. Mar 14, 2023
  5. Feb 02, 2023
  6. Jan 13, 2023
    • Saurabh Kumar's avatar
      Replace flake8 & isort with ruff (#3103) · 5eab4ac4
      Saurabh Kumar authored
      Fixes #3101
      
      - Remove `make sort` and `make sort-fix` make targerts
      - Use `make lint` and `make lint-fix` instead.
      - Make use of GitHub Annotation to surface issues as annotations
      directly in the files changed, similar to CodeQL.
      - Move stuff from `setup.cfg` to `pyproject.toml`
      - Fixed the potentially buggy code. Each of the fix types is in
      individual commits.
      Unverified
      5eab4ac4
  7. Dec 15, 2022
  8. Aug 30, 2022
  9. Aug 28, 2022
    • Saurabh Kumar's avatar
      Improve testing and development experience · 91a25396
      Saurabh Kumar authored
      - Add “make test” command to lint, test and report coverage
      - Add pytest runner 
        - It automatically set up to use the correct Django settings module
        - Runs tests on all the available CPU, I was able to run all the test in total=~30sec using “make test” command.
        - It provides a cleaner error report, compared to DjangoTestRunner
      - Coverage
        - Displayed the report on the terminal after the test finish
        - Disable reporting of coverage for test and migration files
        - Enable coverage reporting for the template files
        - “make test” generates HTML reports to quickly check the coverage of each file
      91a25396
  10. Jan 18, 2021
  11. Feb 25, 2020
    • Todd Dembrey's avatar
      Centralise linting commands in the makefile · 9d0ae152
      Todd Dembrey authored
      - Add missing PHONY definition for `help`
      - Add `lint` command to run both isort and flake8
      - Add `style` command to run flake8
      - Rename `fix` to `sort-fix` to fix the isort errors
      - Remove exit code from `sort` as it hid errors and emits error codes anyway
      9d0ae152
  12. Feb 24, 2020
  13. Jul 22, 2019
  14. Jul 19, 2019
Loading