Skip to content
Snippets Groups Projects
Commit f33e15fd authored by Todd Dembrey's avatar Todd Dembrey
Browse files

GH-961: fixup from rebase

parent 2cfa5ae4
No related branches found
No related tags found
No related merge requests found
...@@ -264,7 +264,7 @@ class StaffReviewOpinionCase(BaseViewTestCase): ...@@ -264,7 +264,7 @@ class StaffReviewOpinionCase(BaseViewTestCase):
staff = StaffFactory() staff = StaffFactory()
review = ReviewFactory(submission=self.submission, author=staff, recommendation_yes=True) review = ReviewFactory(submission=self.submission, author=staff, recommendation_yes=True)
response = self.post_page(review, {'agree': AGREE}) response = self.post_page(review, {'agree': AGREE})
self.assertTrue('agrees' in Activity.objects.first().message) self.assertTrue(review.opinions.first().opinion_display in Activity.objects.first().message)
self.assertEqual(ReviewOpinion.objects.all().count(), 1) self.assertEqual(ReviewOpinion.objects.all().count(), 1)
self.assertEqual(ReviewOpinion.objects.first().opinion, AGREE) self.assertEqual(ReviewOpinion.objects.first().opinion, AGREE)
url = self.url_from_pattern('apply:submissions:reviews:review', kwargs={'submission_pk': self.submission.pk, 'pk': review.id}) url = self.url_from_pattern('apply:submissions:reviews:review', kwargs={'submission_pk': self.submission.pk, 'pk': review.id})
......
...@@ -202,7 +202,7 @@ class ReviewOpinionFormView(CreateView): ...@@ -202,7 +202,7 @@ class ReviewOpinionFormView(CreateView):
related=opinion, related=opinion,
) )
if opinion == DISAGREE: if opinion.opinion == DISAGREE:
return HttpResponseRedirect(reverse('apply:submissions:reviews:form', args=(self.review.submission.pk,))) return HttpResponseRedirect(reverse('apply:submissions:reviews:form', args=(self.review.submission.pk,)))
else: else:
return response return response
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment