diff --git a/opentech/apply/review/tests/test_views.py b/opentech/apply/review/tests/test_views.py index de44234c049fabc1a901c3a891133598def684e2..7a702a758ef8428bee9d2d5ef43731e0fd81fa2d 100644 --- a/opentech/apply/review/tests/test_views.py +++ b/opentech/apply/review/tests/test_views.py @@ -264,7 +264,7 @@ class StaffReviewOpinionCase(BaseViewTestCase): staff = StaffFactory() review = ReviewFactory(submission=self.submission, author=staff, recommendation_yes=True) response = self.post_page(review, {'agree': AGREE}) - self.assertTrue('agrees' in Activity.objects.first().message) + self.assertTrue(review.opinions.first().opinion_display in Activity.objects.first().message) self.assertEqual(ReviewOpinion.objects.all().count(), 1) self.assertEqual(ReviewOpinion.objects.first().opinion, AGREE) url = self.url_from_pattern('apply:submissions:reviews:review', kwargs={'submission_pk': self.submission.pk, 'pk': review.id}) diff --git a/opentech/apply/review/views.py b/opentech/apply/review/views.py index 91e585e72e59421d4fc196628c4493321073b698..5f7e26c07e7cab1956defab3239bb7a80e09dc4e 100644 --- a/opentech/apply/review/views.py +++ b/opentech/apply/review/views.py @@ -202,7 +202,7 @@ class ReviewOpinionFormView(CreateView): related=opinion, ) - if opinion == DISAGREE: + if opinion.opinion == DISAGREE: return HttpResponseRedirect(reverse('apply:submissions:reviews:form', args=(self.review.submission.pk,))) else: return response