Skip to content
Snippets Groups Projects
Commit d07aa852 authored by Erin Mullaney's avatar Erin Mullaney
Browse files

#957 pull out qs to improve performance

parent 29e71438
No related branches found
No related tags found
No related merge requests found
...@@ -159,13 +159,14 @@ class UpdateReviewersForm(forms.ModelForm): ...@@ -159,13 +159,14 @@ class UpdateReviewersForm(forms.ModelForm):
instance.assigned.filter(role=None).exclude(reviewer__in=current_reviewers).delete() instance.assigned.filter(role=None).exclude(reviewer__in=current_reviewers).delete()
# Add new reviewers # Add new reviewers
reviewers_no_role_existing = instance.reviewers.filter(assignedreviewers__role=None)
AssignedReviewers.objects.bulk_create( AssignedReviewers.objects.bulk_create(
AssignedReviewers( AssignedReviewers(
submission=instance, submission=instance,
role=None, role=None,
reviewer=reviewer, reviewer=reviewer,
) for reviewer in current_reviewers ) for reviewer in current_reviewers
if reviewer not in instance.reviewers.filter(assignedreviewers__role=None) if reviewer not in reviewers_no_role_existing
) )
# Update or create role reviewers # Update or create role reviewers
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment