From d07aa8520ef5d6bc24782f41c2418896c9146ec6 Mon Sep 17 00:00:00 2001
From: Erin Mullaney <erin.mullaney@torchbox.com>
Date: Wed, 13 Feb 2019 09:37:23 -0500
Subject: [PATCH] #957 pull out qs to improve performance
---
opentech/apply/funds/forms.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/opentech/apply/funds/forms.py b/opentech/apply/funds/forms.py
index ee2d2e838..1f7fcd2c9 100644
--- a/opentech/apply/funds/forms.py
+++ b/opentech/apply/funds/forms.py
@@ -159,13 +159,14 @@ class UpdateReviewersForm(forms.ModelForm):
instance.assigned.filter(role=None).exclude(reviewer__in=current_reviewers).delete()
# Add new reviewers
+ reviewers_no_role_existing = instance.reviewers.filter(assignedreviewers__role=None)
AssignedReviewers.objects.bulk_create(
AssignedReviewers(
submission=instance,
role=None,
reviewer=reviewer,
) for reviewer in current_reviewers
- if reviewer not in instance.reviewers.filter(assignedreviewers__role=None)
+ if reviewer not in reviewers_no_role_existing
)
# Update or create role reviewers
--
GitLab