Skip to content
Snippets Groups Projects
Commit c4cc96e7 authored by Todd Dembrey's avatar Todd Dembrey
Browse files

Fix the application submission page not working

parent acc7832d
No related branches found
No related tags found
No related merge requests found
......@@ -69,11 +69,11 @@ class UpdateReviewersForm(forms.ModelForm):
def __init__(self, *args, **kwargs):
self.user = kwargs.pop('user')
super().__init__(*args, **kwargs)
reviewers = instance.reviewers.all()
submitted_reviewers = User.objects.filter(id__in=instance.reviews.values('author'))
reviewers = self.instance.reviewers.all()
submitted_reviewers = User.objects.filter(id__in=self.instance.reviews.values('author'))
self.prepare_field('staff_reviewers', reviewers, submitted_reviewers)
if self.can_alter_external_reviewers(instance, user):
if self.can_alter_external_reviewers(self.instance, self.user):
self.prepare_field('reviewer_reviewers', reviewers, submitted_reviewers)
else:
fields.pop('reviewer_reviewers')
......@@ -83,7 +83,7 @@ class UpdateReviewersForm(forms.ModelForm):
field.queryset = field.queryset.exclude(id__in=excluded)
field.initial = initial
def can_alter_external_reviewers(instance, user):
def can_alter_external_reviewers(self, instance, user):
return instance.stage.has_external_review and (user == instance.lead or user.is_superuser)
def save(self, *args, **kwargs):
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment