From c4cc96e7361bc411c2d411d9e9c4cd15455df17e Mon Sep 17 00:00:00 2001 From: Todd Dembrey <todd.dembrey@torchbox.com> Date: Fri, 1 Feb 2019 13:37:18 +0000 Subject: [PATCH] Fix the application submission page not working --- opentech/apply/funds/forms.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/opentech/apply/funds/forms.py b/opentech/apply/funds/forms.py index f4e22d2af..311cbabe4 100644 --- a/opentech/apply/funds/forms.py +++ b/opentech/apply/funds/forms.py @@ -69,11 +69,11 @@ class UpdateReviewersForm(forms.ModelForm): def __init__(self, *args, **kwargs): self.user = kwargs.pop('user') super().__init__(*args, **kwargs) - reviewers = instance.reviewers.all() - submitted_reviewers = User.objects.filter(id__in=instance.reviews.values('author')) + reviewers = self.instance.reviewers.all() + submitted_reviewers = User.objects.filter(id__in=self.instance.reviews.values('author')) self.prepare_field('staff_reviewers', reviewers, submitted_reviewers) - if self.can_alter_external_reviewers(instance, user): + if self.can_alter_external_reviewers(self.instance, self.user): self.prepare_field('reviewer_reviewers', reviewers, submitted_reviewers) else: fields.pop('reviewer_reviewers') @@ -83,7 +83,7 @@ class UpdateReviewersForm(forms.ModelForm): field.queryset = field.queryset.exclude(id__in=excluded) field.initial = initial - def can_alter_external_reviewers(instance, user): + def can_alter_external_reviewers(self, instance, user): return instance.stage.has_external_review and (user == instance.lead or user.is_superuser) def save(self, *args, **kwargs): -- GitLab