Skip to content
Snippets Groups Projects
Commit b186c5d0 authored by Todd Dembrey's avatar Todd Dembrey
Browse files

GH-991: Stop trying to be clever on listing update

parent 87dc69ca
No related branches found
Tags v2.8.1
No related merge requests found
......@@ -45,17 +45,6 @@ export default class GroupedListing extends React.Component {
this.dropdownContainerHeight = this.dropdownContainer.offsetHeight;
}
shouldComponentUpdate(nextProps, nextState) {
const propsToCheck = ['items', 'isLoading', 'isErrored', 'activeItem']
if ( propsToCheck.some(prop => nextProps[prop] !== this.props[prop])) {
return true
}
if ( nextState.orderedItems !== this.state.orderedItems ) {
return true
}
return false
}
componentDidUpdate(prevProps, prevState) {
// Order items
if (this.props.items !== prevProps.items) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment