From b186c5d0cdb7e6b324ee15bec31b79e4ae31111d Mon Sep 17 00:00:00 2001
From: Todd Dembrey <todd.dembrey@torchbox.com>
Date: Wed, 20 Feb 2019 17:12:39 +0000
Subject: [PATCH] GH-991: Stop trying to be clever on listing update
---
.../src/app/src/components/GroupedListing/index.js | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/opentech/static_src/src/app/src/components/GroupedListing/index.js b/opentech/static_src/src/app/src/components/GroupedListing/index.js
index 00c75f0bc..28378b34c 100644
--- a/opentech/static_src/src/app/src/components/GroupedListing/index.js
+++ b/opentech/static_src/src/app/src/components/GroupedListing/index.js
@@ -45,17 +45,6 @@ export default class GroupedListing extends React.Component {
this.dropdownContainerHeight = this.dropdownContainer.offsetHeight;
}
- shouldComponentUpdate(nextProps, nextState) {
- const propsToCheck = ['items', 'isLoading', 'isErrored', 'activeItem']
- if ( propsToCheck.some(prop => nextProps[prop] !== this.props[prop])) {
- return true
- }
- if ( nextState.orderedItems !== this.state.orderedItems ) {
- return true
- }
- return false
- }
-
componentDidUpdate(prevProps, prevState) {
// Order items
if (this.props.items !== prevProps.items) {
--
GitLab