Skip to content
Snippets Groups Projects
Commit 92ca55cd authored by Saurabh Kumar's avatar Saurabh Kumar Committed by Fredrik Jonsson
Browse files

Use robust test for add_screening_status

Do not depend on sorting IDs for checks
parent 77f8739c
No related branches found
No related tags found
No related merge requests found
...@@ -129,13 +129,15 @@ class SubmissionScreeningStatusViewSetTests(APITestCase): ...@@ -129,13 +129,15 @@ class SubmissionScreeningStatusViewSetTests(APITestCase):
data={'id': self.yes_screening_status.id} data={'id': self.yes_screening_status.id}
) )
self.assertEqual(response.status_code, status.HTTP_201_CREATED) self.assertEqual(response.status_code, status.HTTP_201_CREATED)
self.assertEqual(len(response.json()), self.submission.screening_statuses.count()) self.assertEqual(len(response.json()), 2)
first_submission_screening_status = self.submission.screening_statuses.order_by('-id').last()
first_submission_screening_status = self.yes_default_screening_status
self.assertEqual(response.json()[0]['id'], first_submission_screening_status.id) self.assertEqual(response.json()[0]['id'], first_submission_screening_status.id)
self.assertEqual(response.json()[0]['title'], first_submission_screening_status.title) self.assertEqual(response.json()[0]['title'], first_submission_screening_status.title)
self.assertEqual(response.json()[0]['yes'], first_submission_screening_status.yes) self.assertEqual(response.json()[0]['yes'], first_submission_screening_status.yes)
self.assertEqual(response.json()[0]['default'], first_submission_screening_status.default) self.assertEqual(response.json()[0]['default'], first_submission_screening_status.default)
self.assertEqual(response.json()[1]['id'], self.submission.screening_statuses.order_by('id').last().id)
self.assertEqual(response.json()[1]['id'], self.yes_screening_status.id)
def test_staff_can_list_submission_screening_statuses(self): def test_staff_can_list_submission_screening_statuses(self):
user = StaffFactory() user = StaffFactory()
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment