From 92ca55cde75a66105d56a05a3045fb97c3ddc0fe Mon Sep 17 00:00:00 2001
From: Saurabh Kumar <theskumar@users.noreply.github.com>
Date: Mon, 25 Jul 2022 13:05:22 +0530
Subject: [PATCH] Use robust test for add_screening_status
Do not depend on sorting IDs for checks
---
hypha/apply/api/v1/screening/tests/test_views.py | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hypha/apply/api/v1/screening/tests/test_views.py b/hypha/apply/api/v1/screening/tests/test_views.py
index 289da0650..3093eace8 100644
--- a/hypha/apply/api/v1/screening/tests/test_views.py
+++ b/hypha/apply/api/v1/screening/tests/test_views.py
@@ -129,13 +129,15 @@ class SubmissionScreeningStatusViewSetTests(APITestCase):
data={'id': self.yes_screening_status.id}
)
self.assertEqual(response.status_code, status.HTTP_201_CREATED)
- self.assertEqual(len(response.json()), self.submission.screening_statuses.count())
- first_submission_screening_status = self.submission.screening_statuses.order_by('-id').last()
+ self.assertEqual(len(response.json()), 2)
+
+ first_submission_screening_status = self.yes_default_screening_status
self.assertEqual(response.json()[0]['id'], first_submission_screening_status.id)
self.assertEqual(response.json()[0]['title'], first_submission_screening_status.title)
self.assertEqual(response.json()[0]['yes'], first_submission_screening_status.yes)
self.assertEqual(response.json()[0]['default'], first_submission_screening_status.default)
- self.assertEqual(response.json()[1]['id'], self.submission.screening_statuses.order_by('id').last().id)
+
+ self.assertEqual(response.json()[1]['id'], self.yes_screening_status.id)
def test_staff_can_list_submission_screening_statuses(self):
user = StaffFactory()
--
GitLab