Skip to content
Snippets Groups Projects
Commit 7d3aba64 authored by Todd Dembrey's avatar Todd Dembrey
Browse files

fixup! GH-858: tidy up messaging recipients and formatting

parent 74815023
No related branches found
No related tags found
No related merge requests found
......@@ -393,7 +393,7 @@ class SlackAdapter(AdapterBase):
)
)
def notify_reviewers(self, submission, links, **kwargs):
def notify_reviewers(self, submission, link, **kwargs):
reviewers_to_notify = []
for reviewer in submission.reviewers.all():
if submission.phase.permissions.can_review(reviewer):
......@@ -405,16 +405,17 @@ class SlackAdapter(AdapterBase):
return (
'<{link}|{submission.title}> is ready for review. The following are assigned as reviewers: {reviewers}'.format(
link=links[submission.id],
link=link,
reviewers=reviewers,
submission=submission,
)
)
def batch_notify_reviewers(self, submissions, **kwargs):
def batch_notify_reviewers(self, submissions, links, **kwargs):
kwargs.pop('submission')
kwargs.pop('link')
return '. '.join(
self.notify_reviewers(submission, **kwargs)
self.notify_reviewers(submission, link=links[submission.id], **kwargs)
for submission in submissions
)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment