From 7d3aba641a9f9ca04c10f432971d9bbbab0a0dc3 Mon Sep 17 00:00:00 2001
From: Todd Dembrey <todd.dembrey@torchbox.com>
Date: Thu, 21 Feb 2019 11:59:44 +0000
Subject: [PATCH] fixup! GH-858: tidy up messaging recipients and formatting
---
opentech/apply/activity/messaging.py | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/opentech/apply/activity/messaging.py b/opentech/apply/activity/messaging.py
index b8538e585..7e1a38ddf 100644
--- a/opentech/apply/activity/messaging.py
+++ b/opentech/apply/activity/messaging.py
@@ -393,7 +393,7 @@ class SlackAdapter(AdapterBase):
)
)
- def notify_reviewers(self, submission, links, **kwargs):
+ def notify_reviewers(self, submission, link, **kwargs):
reviewers_to_notify = []
for reviewer in submission.reviewers.all():
if submission.phase.permissions.can_review(reviewer):
@@ -405,16 +405,17 @@ class SlackAdapter(AdapterBase):
return (
'<{link}|{submission.title}> is ready for review. The following are assigned as reviewers: {reviewers}'.format(
- link=links[submission.id],
+ link=link,
reviewers=reviewers,
submission=submission,
)
)
- def batch_notify_reviewers(self, submissions, **kwargs):
+ def batch_notify_reviewers(self, submissions, links, **kwargs):
kwargs.pop('submission')
+ kwargs.pop('link')
return '. '.join(
- self.notify_reviewers(submission, **kwargs)
+ self.notify_reviewers(submission, link=links[submission.id], **kwargs)
for submission in submissions
)
--
GitLab