Skip to content
Snippets Groups Projects
Commit 9cd0a751 authored by Karl Fogel's avatar Karl Fogel
Browse files

Give more explanation in the "Obvious Fix" rule

parent 21d8f3dc
No related branches found
No related tags found
No related merge requests found
...@@ -129,15 +129,24 @@ include things like fixes for obvious typos (e.g., a misspelling in a ...@@ -129,15 +129,24 @@ include things like fixes for obvious typos (e.g., a misspelling in a
comment or in a user-visible string), source code formatting changes comment or in a user-visible string), source code formatting changes
(e.g., removing trailing whitespace from lines in preparation for a (e.g., removing trailing whitespace from lines in preparation for a
substantive change to follow, as per the ["keep unrelated changes substantive change to follow, as per the ["keep unrelated changes
separate"](#keep-unrelated-changes-separate) rule), etc. You may use separate"](#keep-unrelated-changes-separate) rule), etc.
your judgement about what constitutes a trivial change. After all,
everything is under version control, so if someone makes a mistake, or The purpose of this exception is to avoid paying the costs of the
there is disagreement about the effects of the change, then we can review process in situations where it's unlikely to bring benefits.
roll back and discuss. Going through review is good for quality, but it reduces velocity and
increases the state-maintenance burden for contributors -- an unlanded
change takes up space in people's minds as well as on MR lists. For
most changes, that cost is worth paying, but not for all.
You may use your judgement about what constitutes a trivial change.
Everything is under version control, so if someone makes a mistake, or
there is disagreement about the effects of the change, then the group
can roll back and discuss.
Note that individual projects may use stricter review guidelines, if Note that individual projects may use stricter review guidelines, if
the development team wants to. Specifically, some projects don't make the development team chooses to. Specifically, some projects don't
the "obvious fix" exception: everything goes through pre-merge review. make the "obvious fix" exception, and prefer instead that everything
go through pre-merge review.
## No surprise rebasing ## No surprise rebasing
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment