Skip to content

Convert smartfilter CSS to LESS

Justin Reese requested to merge 67-remove-css-nesting into main

CSS nesting is really, really handy. It makes rules more concise and legible — two very important attributes for avoiding bugs and improving development.

Native CSS nesting has been supported by all major browsers for a year (cf. Can I Use), but after deploying we discovered two core team members whose browser versions were more than a year old. That’s not a good success rate.

This PR converts files that use CSS nesting to LESS. (It also required a special syntax to distinguish CSS native calc() functions from LESS’s calc() function.)

We will convert back to native CSS when we have more evidence to support the safety of doing so.

Addresses torque#67 (but need to confirm w/Karl before closing)

Merge request reports

Loading