Skip to content
Snippets Groups Projects

fix-csv should be fix_csv

    • Closed Issue created by Frank Duncan @frankduncan

    Created by: jvasile

    PEP 8 discourages underscores in module and package names. If somebody wanted to build on fix-csv, they couldn't just do import fix-csv. Instead, they would have to do python_code = __import__('fix-csv').

    I'm not sure if there is anything in fix-csv that somebody might want to build on, but renaming this file will make it more pythonic.

    Designs

      Child items 0

      2. No child items are currently assigned. Use child items to break down this issue into smaller parts.

      Activity

      • Frank Duncan
        Frank Duncan @frankduncan ·
        Author Owner

        Created by: kfogel

        Underscore is discouraged only in package names, not in module names. In any case, we switched to underscore, not away; if we were going to take the advice we thought the PEP was giving, we would have called the thing fixcsv :-). But let's just revert the whole batch. This isn't a package anyway, it's at most a module, and hyphen is more common for file names (and easier on most keyboards to type).

      Please register or sign in to reply