Skip to content

Improve Makefile to reduce venv inefficiency and sourcing difficulty

James Vasile requested to merge makefile-improvements into main

  • Trying to build the venv and upgrade pip when it already exists on every single run is not necessary. Let the Makefile manage that for us.

  • sourcing venv/bin/activate doesn't work in make's default shell, which is sh (not bash). We could add 'SHELL=/bin/bash' to the Makefile (and maybe we should) but here I just sidestep it by removing source from the commands and calling the venv's bins directly.

  • Re-enable format for running black

  • Quiet pip a bit, just because we run it every time we do make run.

Merge request reports