Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
H
hypha
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
ots
hypha
Merge requests
!23
Add ReviewOpinion delete functionality to review sidebar (#3565)
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Add ReviewOpinion delete functionality to review sidebar (#3565)
lfc-merge-upstream
into
lfc-main
Overview
0
Commits
15
Pipelines
0
Changes
1
Merged
Frank Duncan
requested to merge
lfc-merge-upstream
into
lfc-main
1 year ago
Overview
0
Commits
15
Pipelines
0
Changes
1
Expand
Fixes #3527
0
0
Merge request reports
Viewing commit
d676771a
Prev
Next
Show latest version
1 file
+
6
−
9
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Unverified
d676771a
Add slack notification for reviewers on review submit by the role reviewers (#3433)
· d676771a
Sandeep Chauhan
authored
1 year ago
Fixes #3421
hypha/apply/activity/adapters/slack.py
+
6
−
9
Options
@@ -174,16 +174,13 @@ class SlackAdapter(AdapterBase):
recipients
=
[
self
.
slack_id
(
source
.
lead
)]
# Notify second reviewer when first reviewer is done.
if
message_type
==
MESSAGES
.
NEW_REVIEW
and
related
:
if
message_type
in
[
MESSAGES
.
NEW_REVIEW
,
MESSAGES
.
REVIEW_OPINION
]
and
related
:
submission
=
source
if
(
submission
.
assigned
.
with_roles
().
count
()
==
2
and
related
.
author
.
reviewer
==
submission
.
assigned
.
with_roles
().
first
().
reviewer
):
recipients
.
append
(
self
.
slack_id
(
submission
.
assigned
.
with_roles
().
last
().
reviewer
)
)
role_reviewers
=
[
role_reviewer
.
reviewer
for
role_reviewer
in
submission
.
assigned
.
with_roles
()]
if
related
.
author
.
reviewer
in
role_reviewers
:
for
reviewer
in
role_reviewers
:
if
reviewer
!=
related
.
author
.
reviewer
:
recipients
.
append
(
self
.
slack_id
(
reviewer
))
if
message_type
==
MESSAGES
.
UPDATE_INVOICE_STATUS
:
if
related
.
status
in
[
Loading