Skip to content
Snippets Groups Projects
  1. Mar 13, 2025
  2. Mar 12, 2025
  3. Mar 09, 2025
    • Jesse Bickel's avatar
      Use django-file-form 3.8.2 for case insensitivity · 2bbc4ee5
      Jesse Bickel authored
      Before version 3.8.1, there was an issue where file extension name
      matching was case sensitive. This was seen on a submission page or any
      other page that used a file upload stream form. With 3.8.2 the match
      is done without case sensitivity. There is therefore no need for wonky
      globs in the list of acceptable file extensions.
      
      Issue ots/clients/ardc/hypha-tracker#342: Permit users to upload files
          to the Comments section of Submissions
      Issue ots/clients/ardc/hypha-tracker#389: Submissions: Regex in
          "Accepted file types" text
      2bbc4ee5
  4. Mar 06, 2025
    • Jesse Bickel's avatar
      Make all submission fields optional for drafts · 77419fb6
      Jesse Bickel authored
      This appears to have been the intent in the code for some time, but
      these three have been special snowflakes every now and then: Title,
      Email, Full Name. With this commit, they are no longer exceptions to
      the rule that drafts have no required fields on submissions.
      
      Issue ots/clients/ardc/hypha-tracker#279: Can save draft with missing
          fields when editing draft
      77419fb6
    • Frank Duncan's avatar
      Add revisions, activity items when drafts are saved · 4d539db3
      Frank Duncan authored
      This effectively adds an audit trail for changes to applications by both
      applicants and staff during the draft phase of a submission.  While a
      bit noisier than base hypha, more audit trail is better than less.
      
      A consideration while doing this was to only do revisions when someone
      other than the applicant made edits to the draft.  However, that made
      the diffs for when a non applicant did edit look larger than they were.
      
      Fixes ots/clients/ardc/hypha-tracker#341: Permit Staff to edit
      draft applications
      4d539db3
    • Lily Ye's avatar
      Update QA doc to be more efficient and complete · 55fe250e
      Lily Ye authored
      - Re-order testing for more streamlined QA worflow
      - No previously existing testing removed, only moved
      - Place draft and submission fails before passes
      - Add additional tests
      - Add known and "won't fix" bug
      55fe250e
  5. Mar 05, 2025
  6. Mar 04, 2025
  7. Mar 03, 2025
    • Jesse Bickel's avatar
      Threaded comments · 3ca32c68
      Jesse Bickel authored
      Allow users to reply to comments by clicking a new "Reply" button.
      There will only be one level of reply to avoid query complexity and
      recursive indentation hell. There are two UI clues that a comment is a
      reply: indentation and "replied" rather than "commented."
      
      The order for top-level comments is "latest first" while the order for
      replies to a top-level comment is the more natural "earliest first."
      
      Implementation details follow.
      
      A new property on Activity named `in_reply_to` tracks comment replies.
      On the relevant pages and snippets, use several new Alpine `x-data`
      variables to track whether a comment is a reply or not. There are some
      assumptions made about IDs and these variables between HTML pages and
      partial pages.
      
      In order for migrations to succeed on a fresh database, for example a
      database migrated during automated tests, an older migration needed to
      be nerfed. It had made use of an Activity object during a migration.
      
      Issue ots/clients/ardc/hypha-tracker#356: Threaded comments
      3ca32c68
    • Frank Duncan's avatar
      Merge branch 'ardc-107-comment-visibility-default' into 'ardc-main' · d33fc78e
      Frank Duncan authored
      Make default comment visibility a system setting
      
      See merge request !117
      d33fc78e
    • Frank Duncan's avatar
      Merge branch 'ardc-385-score-box-size' into 'ardc-main' · 108ab0d2
      Frank Duncan authored
      Fix score box height
      
      See merge request !114
      108ab0d2
  8. Feb 19, 2025
  9. Feb 17, 2025
    • Jesse Bickel's avatar
      Allow upload of mixed-case file extensions · 614246a2
      Jesse Bickel authored
      This workaround allows mixed case file extensions. The issue appears
      to be that django's `accepted_file_types.ts` does not include the
      `{nocase: true}` option in its call to `picomatch.isMatch` so even
      though the back-end is OK with any case, the front-end is not and
      needs these extra matches. It is not sufficient to include only these
      new patterns, either, because the file browser dropdown needs the
      lowercase ones.
      
      Perhaps there is a better way but this is today's "fix."
      
      Issue ots/clients/ardc/hypha-tracker#342: Permit users to upload files
          to the Comments section of Submissions
      614246a2
    • Jesse Bickel's avatar
      Merge branch 'ardc-369-let-reviewers-see-all-reviews' into 'ardc-main' · 22640691
      Jesse Bickel authored
      Reviewers can View All reviews
      
      See merge request !115
      22640691
    • Jesse Bickel's avatar
      Reviewers can View All reviews · de510680
      Jesse Bickel authored
      Issue ots/clients/ardc/hypha-tracker#369: Give Reviewers the ability
          to view all reviews
      de510680
    • Frank Duncan's avatar
      Fix alpinejs discrepencies, typos in review score · 87319ede
      Frank Duncan authored
      alpinejs, when using x-show, doesn't need the element to be hidden, as
      it will take care of that.  Also, x-clock should be x-cloak
      87319ede
  10. Feb 14, 2025
  11. Feb 13, 2025
  12. Feb 11, 2025
  13. Feb 04, 2025
  14. Feb 03, 2025
Loading