Skip to content
Snippets Groups Projects
Commit ee286ac5 authored by Frank Duncan's avatar Frank Duncan
Browse files

Remove None reviewers from validation 

This was caused by an issue where the "---" (None) reviewers were
causing the validation to fail, meaning that you had to fill out n-1
reviewers in the submission page in order for the save to go through.

The solution was to only check for duplicates with reviewers that were
selected.

Issue ots/clients/smex/hypha-tracker#2: Can't assign Staff
as reviewers of applications
parent 586406f5
No related branches found
No related tags found
No related merge requests found
Hide whitespace changes
Inline Side-by-side
  • Karl Fogel @kfogel ·
    Owner

    @frankduncan This catches the problem in class UpdateReviewersForm, but I think the same problem exists in class BatchUpdateReviewersForm later in the file? (Line 399 of hypha/apply/funds/forms.py in upstream as of commit 4ed9e567, but I think line 429 in the version of the file here.)

    /CC @jimmcgowan -- Jim, this is the thing I mentioned today when we were talking.

  • Frank Duncan @frankduncan

    mentioned in commit faf276bd

     ·

    mentioned in commit faf276bd

    Toggle commit list
  • Frank Duncan @frankduncan

    mentioned in commit 68d331fc

     ·

    mentioned in commit 68d331fc

    Toggle commit list
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment