Skip to content
Snippets Groups Projects
Commit cc753fdb authored by Erin Mullaney's avatar Erin Mullaney Committed by Todd Dembrey
Browse files

#962 opinion display review detail block

parent c1008ef3
No related branches found
No related tags found
No related merge requests found
...@@ -13,11 +13,11 @@ ...@@ -13,11 +13,11 @@
{% endif %} {% endif %}
{% for review_data in reviews_block.role_reviewed %} {% for review_data in reviews_block.role_reviewed %}
{% include 'funds/includes/review_table_row.html' with review=review_data.review reviewer=review_data.reviewer role=review_data.role %} {% include 'funds/includes/review_table_row.html' with review=review_data.review reviewer=review_data.reviewer role=review_data.role opinions=review_data.opinions %}
{% endfor %} {% endfor %}
{% for review_data in reviews_block.staff_reviewed %} {% for review_data in reviews_block.staff_reviewed %}
{% include 'funds/includes/review_table_row.html' with review=review_data.review reviewer=review_data.reviewer %} {% include 'funds/includes/review_table_row.html' with review=review_data.review reviewer=review_data.reviewer opinions=review_data.opinions %}
{% endfor %} {% endfor %}
{% for review_data in reviews_block.role_not_reviewed %} {% for review_data in reviews_block.role_not_reviewed %}
......
...@@ -31,3 +31,15 @@ ...@@ -31,3 +31,15 @@
<td>{{ review.get_score_display }}</td> <td>{{ review.get_score_display }}</td>
{% endif %} {% endif %}
</tr> </tr>
{% for opinion in opinions %}
<tr class="tr--subchild">
<td class="reviews-sidebar__author" colspan="2">
<span>
{{ opinion.author }}
{% if opinion.role %}{% image opinion.role.icon max-12x12 %}{% endif %}
</span>
</td>
<td></td>
<td>{{ opinion.opinion }}</td>
</tr>
{% endfor %}
...@@ -51,11 +51,23 @@ class ReviewContextMixin: ...@@ -51,11 +51,23 @@ class ReviewContextMixin:
else: else:
key = 'external_not_reviewed' key = 'external_not_reviewed'
reviews_block[key].append({ review_info_dict = {
'reviewer': reviewer, 'reviewer': reviewer,
'review': review, 'review': review,
'role': role, 'role': role,
}) }
opinions_list = []
if review and review.opinions:
for opinion in review.opinions.all():
author_role = self.object.assigned.with_roles().filter(reviewer=opinion.author).first()
role = author_role.role if author_role else None
opinions_list.append({
'author': opinion.author,
'opinion': opinion.get_opinion_display(),
'role': role,
})
review_info_dict['opinions'] = opinions_list
reviews_block[key].append(review_info_dict)
# Calculate the recommendation based on role and staff reviews # Calculate the recommendation based on role and staff reviews
recommendation = self.object.reviews.by_staff().recommendation() recommendation = self.object.reviews.by_staff().recommendation()
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment