Add tests for review and determination form's admin view

hypha/apply/determinations/tests/test_admin_views.py

+import factory
+from django.contrib.messages import get_messages
+from django.test import TestCase
+from django.urls import reverse
+
+from hypha.apply.determinations.models import DeterminationForm
+from hypha.apply.funds.tests.test_admin_views import create_form_fields_data
+from hypha.apply.users.tests.factories import SuperUserFactory
+
+
+class TestCreateDeterminationFormView(TestCase):
+    @classmethod
+    def setUpTestData(cls):
+        cls.user = SuperUserFactory()
+        cls.label_help_text_data = {
+            'field_label': factory.Faker('sentence').evaluate(None, None, {'locale': None}),
+            'help_text': factory.Faker('sentence').evaluate(None, None, {'locale': None})
+        }
+        cls.name = factory.Faker('name').evaluate(None, None, {'locale': None})
+
+    def create_page(self, data):
+        self.client.force_login(self.user)
+        url = reverse('determinations_determinationform_modeladmin_create')
+        response = self.client.post(url, data=data, secure=True, follow=True)
+        return response
+
+    def test_name_field_required(self):
+        data = {'name': ['']}
+        form_field_data = create_form_fields_data(
+            {
+                'determination': self.label_help_text_data,
+                'message': self.label_help_text_data,
+            }
+        )
+        data.update(form_field_data)
+        response = self.create_page(data=data)
+
+        expected_message = 'This field is required.'
+        for message in get_messages(response.context['request']):
+            self.assertEqual(expected_message, str(message.message).strip())
+        self.assertEqual(DeterminationForm.objects.count(), 0)
+
+    def test_determination_block_required(self):
+        data = {'name': [self.name]}
+        form_field_data = create_form_fields_data(
+            {
+                'message': self.label_help_text_data,
+            }
+        )
+        data.update(form_field_data)
+        response = self.create_page(data=data)
+
+        expected_message = 'You are missing the following required fields: Determination'
+        for message in get_messages(response.context['request']):
+            self.assertEqual(expected_message, str(message.message).strip())
+        self.assertEqual(DeterminationForm.objects.count(), 0)
+
+    def test_message_block_required(self):
+        data = {'name': [self.name]}
+        form_field_data = create_form_fields_data(
+            {
+                'determination': self.label_help_text_data,
+            }
+        )
+        data.update(form_field_data)
+        response = self.create_page(data=data)
+
+        expected_message = 'You are missing the following required fields: Message'
+        for message in get_messages(response.context['request']):
+            self.assertEqual(expected_message, str(message.message).strip())
+        self.assertEqual(DeterminationForm.objects.count(), 0)
+
+    def test_field_label_required(self):
+        data = {'name': [self.name]}
+        form_field_data = create_form_fields_data(
+            {
+                'determination': {},
+                'message': {},
+            }
+        )
+        data.update(form_field_data)
+        response = self.create_page(data=data)
+
+        expected_messages_list = ['Label cannot be empty for Determination', 'Label cannot be empty for Message']
+        for message in get_messages(response.context['request']):
+            self.assertIn(str(message.message).strip(), expected_messages_list)
+        self.assertEqual(DeterminationForm.objects.count(), 0)
+
+    def test_form_creation(self):
+        data = {'name': [self.name]}
+        form_field_data = create_form_fields_data(
+            {
+                'determination': self.label_help_text_data,
+                'message': self.label_help_text_data,
+            }
+        )
+        data.update(form_field_data)
+        response = self.create_page(data=data)
+
+        self.assertEqual(response.status_code, 200)
+        self.assertEqual(DeterminationForm.objects.count(), 1)

hypha/apply/funds/tests/test_admin_views.py

@@ -157,7 +157,7 @@ class TestCreateApplicationFormView(TestCase):
             self.assertEqual(expected_message, str(message.message).strip())
         self.assertEqual(ApplicationForm.objects.count(), 0)
 
-    def test_title_is_required(self):
+    def test_title_block_required(self):
         data = {'name': [self.name]}
         form_field_data = create_form_fields_data(
             {
@@ -173,7 +173,7 @@ class TestCreateApplicationFormView(TestCase):
             self.assertEqual(expected_message, str(message.message).strip())
         self.assertEqual(ApplicationForm.objects.count(), 0)
 
-    def test_email_is_required(self):
+    def test_email_block_required(self):
         data = {'name': [self.name]}
         form_field_data = create_form_fields_data(
             {
@@ -189,7 +189,7 @@ class TestCreateApplicationFormView(TestCase):
             self.assertEqual(expected_message, str(message.message).strip())
         self.assertEqual(ApplicationForm.objects.count(), 0)
 
-    def test_full_name_is_required(self):
+    def test_full_name_block_required(self):
         data = {'name': [self.name]}
         form_field_data = create_form_fields_data(
             {

hypha/apply/review/tests/test_admin_views.py

+import factory
+from django.contrib.messages import get_messages
+from django.test import TestCase
+from django.urls import reverse
+
+from hypha.apply.funds.tests.test_admin_views import create_form_fields_data
+from hypha.apply.review.models import ReviewForm
+from hypha.apply.users.tests.factories import SuperUserFactory
+
+
+class TestCreateReviewFormView(TestCase):
+    @classmethod
+    def setUpTestData(cls):
+        cls.user = SuperUserFactory()
+        cls.label_help_text_data = {
+            'field_label': factory.Faker('sentence').evaluate(None, None, {'locale': None}),
+            'help_text': factory.Faker('sentence').evaluate(None, None, {'locale': None})
+        }
+        cls.name = factory.Faker('name').evaluate(None, None, {'locale': None})
+
+    def create_page(self, data):
+        self.client.force_login(self.user)
+        url = reverse('review_reviewform_modeladmin_create')
+        response = self.client.post(url, data=data, secure=True, follow=True)
+        return response
+
+    def test_name_field_required(self):
+        data = {'name': ['']}
+        form_field_data = create_form_fields_data(
+            {
+                'recommendation': self.label_help_text_data,
+                'comments': self.label_help_text_data,
+                'visibility': self.label_help_text_data,
+            }
+        )
+        data.update(form_field_data)
+        response = self.create_page(data=data)
+
+        expected_message = 'This field is required.'
+        for message in get_messages(response.context['request']):
+            self.assertEqual(expected_message, str(message.message).strip())
+        self.assertEqual(ReviewForm.objects.count(), 0)
+
+    def test_recommendation_block_required(self):
+        data = {'name': [self.name]}
+        form_field_data = create_form_fields_data(
+            {
+                'comments': self.label_help_text_data,
+                'visibility': self.label_help_text_data,
+            }
+        )
+        data.update(form_field_data)
+        response = self.create_page(data=data)
+
+        expected_message = 'You are missing the following required fields: Recommendation'
+        for message in get_messages(response.context['request']):
+            self.assertEqual(expected_message, str(message.message).strip())
+        self.assertEqual(ReviewForm.objects.count(), 0)
+
+    def test_comments_block_required(self):
+        data = {'name': [self.name]}
+        form_field_data = create_form_fields_data(
+            {
+                'recommendation': self.label_help_text_data,
+                'visibility': self.label_help_text_data,
+            }
+        )
+        data.update(form_field_data)
+        response = self.create_page(data=data)
+
+        expected_message = 'You are missing the following required fields: Comments'
+        for message in get_messages(response.context['request']):
+            self.assertEqual(expected_message, str(message.message).strip())
+        self.assertEqual(ReviewForm.objects.count(), 0)
+
+    def test_visibility_block_required(self):
+        data = {'name': [self.name]}
+        form_field_data = create_form_fields_data(
+            {
+                'recommendation': self.label_help_text_data,
+                'comments': self.label_help_text_data,
+            }
+        )
+        data.update(form_field_data)
+        response = self.create_page(data=data)
+
+        expected_message = 'You are missing the following required fields: Visibility'
+        for message in get_messages(response.context['request']):
+            self.assertEqual(expected_message, str(message.message).strip())
+        self.assertEqual(ReviewForm.objects.count(), 0)
+
+    def test_field_label_required(self):
+        data = {'name': [self.name]}
+        form_field_data = create_form_fields_data(
+            {
+                'recommendation': {},
+                'comments': {},
+                'visibility': {},
+            }
+        )
+        data.update(form_field_data)
+        response = self.create_page(data=data)
+
+        expected_messages_list = ['Label cannot be empty for Recommendation', 'Label cannot be empty for Comments', 'Label cannot be empty for Visibility']
+        for message in get_messages(response.context['request']):
+            self.assertIn(str(message.message).strip(), expected_messages_list)
+        self.assertEqual(ReviewForm.objects.count(), 0)
+
+    def test_form_creation(self):
+        data = {'name': [self.name]}
+        form_field_data = create_form_fields_data(
+            {
+                'recommendation': self.label_help_text_data,
+                'comments': self.label_help_text_data,
+                'visibility': self.label_help_text_data,
+            }
+        )
+        data.update(form_field_data)
+        response = self.create_page(data=data)
+
+        self.assertEqual(response.status_code, 200)
+        self.assertEqual(ReviewForm.objects.count(), 1)

hypha/apply/utils/blocks.py

@@ -7,7 +7,7 @@ from django.utils.safestring import mark_safe
 from django.utils.translation import gettext_lazy as _
 from pagedown.widgets import PagedownWidget
 from wagtail.admin import messages
-from wagtail.core.blocks import  ListBlock, StaticBlock, StreamBlock, StreamValue
+from wagtail.core.blocks import ListBlock, StaticBlock, StreamBlock, StreamValue
 
 from hypha.apply.stream_forms.blocks import (
     FormFieldBlock,