Skip to content
Snippets Groups Projects
Unverified Commit a01725e9 authored by Fredrik Jonsson's avatar Fredrik Jonsson Committed by GitHub
Browse files

Merge pull request #966 from OpenTechFund/fix/notifications-for-ready-for-review

Remove staff Slack notifications and staff e-mails for READY_FOR_REVIEW.
parents 719afaf1 fca360ee
No related branches found
No related tags found
No related merge requests found
......@@ -329,7 +329,7 @@ class SlackAdapter(AdapterBase):
reviewers_to_notify.append(reviewer)
reviewers = ', '.join(
self.slack_id(reviewer) or str(reviewer) for reviewer in reviewers_to_notify
str(reviewer) for reviewer in reviewers_to_notify
)
return (
......@@ -439,7 +439,7 @@ class EmailAdapter(AdapterBase):
return [
reviewer.email
for reviewer in submission.missing_reviewers.all()
if submission.phase.permissions.can_review(reviewer)
if submission.phase.permissions.can_review(reviewer) and not reviewer.is_apply_staff
]
def render_message(self, template, **kwargs):
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment