feature: show review count as fraction (#3300)

Visual enhancement of Reviews column in All submission table. Adds a
slash between completed reviews and assigned reviewers.

Closes #3299

---------

Co-authored-by: Chris Zubak-Skees <chriszs@gmail.com>

hypha/apply/funds/tables.py

@@ -132,7 +132,7 @@ class LabeledCheckboxColumn(tables.CheckBoxColumn):
 
 class BaseAdminSubmissionsTable(SubmissionsTable):
     lead = tables.Column(order_by=('lead__full_name',))
-    reviews_stats = tables.TemplateColumn(template_name='funds/tables/column_reviews.html', verbose_name=mark_safe("Reviews<div>Assgn.\tComp.</div>"), orderable=False)
+    reviews_stats = tables.TemplateColumn(template_name='funds/tables/column_reviews.html', verbose_name=mark_safe("Reviews<div>Comp. <span class=\"counts-separator\">/</span> Assgn.</div>"), orderable=False)
     screening_status = tables.Column(verbose_name=_('Screening'), accessor='screening_statuses')
 
     class Meta(SubmissionsTable.Meta):

hypha/apply/funds/templates/funds/tables/column_reviews.html

@@ -3,13 +3,16 @@
 <table class="reviews-summary">
     <tr class="reviews-summary__tr">
         <td class="reviews-summary__td">
-            {% if record.stage.has_external_review %}
-                {{ record.review_count|default:'0' }}
-            {% else %}
-                {{ record.review_staff_count|default:'0' }}
-            {% endif %}
+            <div class="reviews-summary__td-width">
+                {{ record.review_submitted_count|default:'0' }} 
+                <span class="counts-separator">/</span>
+                {% if record.stage.has_external_review %}
+                    {{ record.review_count|default:'0' }}
+                {% else %}
+                    {{ record.review_staff_count|default:'0' }}
+                {% endif %}
+            </div>
         </td>
-        <td class="reviews-summary__td">{{ record.review_submitted_count|default:'0' }}</td>
         <td class="reviews-summary__td">{{ record.review_recommendation|traffic_light }}</td>
     </tr>
 </table>

hypha/apply/review/templatetags/review_tags.py

@@ -29,7 +29,7 @@ def traffic_light(value):
     try:
         return mark_safe(TRAFFIC_LIGHT_TEMPLATE.format(**TRAFFIC_LIGHT_COLORS[value]))
     except KeyError:
-        return '-'
+        return ''
 
 
 @register.filter

hypha/static_src/src/sass/apply/components/_reviews-summary.scss

@@ -14,5 +14,14 @@
     &__td {
         padding: 10px;
         vertical-align: middle;
+        text-align: center;
     }
+
+    &__td-width {
+        width: max-content;
+    }
+}
+
+.counts-separator {
+    color: $color--mid-grey;
 }