Skip to content
Snippets Groups Projects
Commit 71b1d084 authored by Parbhat Puri's avatar Parbhat Puri
Browse files

review display view permission updates

parent 042c32ab
No related branches found
No related tags found
No related merge requests found
...@@ -174,17 +174,19 @@ class ReviewDisplay(DetailView): ...@@ -174,17 +174,19 @@ class ReviewDisplay(DetailView):
submission = review.submission submission = review.submission
partner_has_access = submission.partners.filter(pk=request.user.pk).exists() partner_has_access = submission.partners.filter(pk=request.user.pk).exists()
if user.is_reviewer and not user.is_apply_staff: if user.is_apply_staff:
pass
elif user.is_reviewer:
if user != author and not review.reviewer_visibility: if user != author and not review.reviewer_visibility:
raise PermissionDenied raise PermissionDenied
elif user.is_partner: elif user.is_partner:
if user != author and not (partner_has_access and review.reviewer_visibility): if user != author and not (partner_has_access and review.reviewer_visibility):
raise PermissionDenied raise PermissionDenied
elif user.is_community_reviewer: elif user.is_community_reviewer:
if user != author and not (submission.community_review and review.reviewer_visibility): if user != author and not (submission.community_review and review.reviewer_visibility):
raise PermissionDenied raise PermissionDenied
else:
raise PermissionDenied
if review.is_draft: if review.is_draft:
return HttpResponseRedirect(reverse_lazy('apply:submissions:reviews:form', args=(review.submission.id,))) return HttpResponseRedirect(reverse_lazy('apply:submissions:reviews:form', args=(review.submission.id,)))
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment