Skip to content
Snippets Groups Projects
Commit 6e2aaaf5 authored by Todd Dembrey's avatar Todd Dembrey Committed by Fredrik Jonsson
Browse files

GH-1191: Make sure the review ordering is correct

parent b0fe849f
No related branches found
No related tags found
No related merge requests found
...@@ -802,11 +802,17 @@ class AssignedReviewersQuerySet(models.QuerySet): ...@@ -802,11 +802,17 @@ class AssignedReviewersQuerySet(models.QuerySet):
type_order=models.Case( type_order=models.Case(
*ordering, *ordering,
output_field=models.IntegerField(), output_field=models.IntegerField(),
),
has_review=models.Case(
models.When(review__isnull=True, then=models.Value(1)),
models.When(review__is_draft=True, then=models.Value(1)),
default=models.Value(0),
output_field=models.IntegerField(),
) )
).order_by( ).order_by(
F('role__order').asc(nulls_last=True),
'type_order', 'type_order',
F('review__pk').asc(nulls_last=True), 'has_review',
F('role__order').asc(nulls_last=True),
).select_related( ).select_related(
'reviewer', 'reviewer',
'role', 'role',
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment