GH-1147: Partner can edit whenever applicant can in addition to ac review phase

opentech/apply/funds/models/submissions.py

@@ -34,7 +34,7 @@ from ..workflow import (
     active_statuses,
     DETERMINATION_RESPONSE_PHASES,
     get_review_active_statuses,
-    get_edit_or_review_active_statuses,
+    get_edit_review_active_statuses,
     INITIAL_STATE,
     PHASES,
     review_statuses,
@@ -103,7 +103,7 @@ class ApplicationSubmissionQueryset(JSONOrderable):
         return self.filter(reviews__author=user)
 
     def partner_for(self, user):
-        user_edit_review_statuses = get_edit_or_review_active_statuses(user)
+        user_edit_review_statuses = get_edit_review_active_statuses(user)
         return self.filter(partners=user, status__in=user_edit_review_statuses)
 
     def awaiting_determination_for(self, user):

opentech/apply/funds/workflow.py

@@ -166,7 +166,7 @@ reviewer_review_permissions = make_permissions(edit=[staff_can, partner_can], re
 
 community_review_permissions = make_permissions(edit=[staff_can], review=[staff_can, reviewer_can, community_can])
 
-applicant_edit_permissions = make_permissions(edit=[applicant_can], review=[staff_can])
+applicant_edit_permissions = make_permissions(edit=[applicant_can, partner_can], review=[staff_can])
 
 staff_applicant_edit_permissions = make_permissions(edit=[staff_can, applicant_can])
 
@@ -871,7 +871,7 @@ def get_review_active_statuses(user=None):
     return reviews
 
 
-def get_edit_or_review_active_statuses(user=None):
+def get_edit_review_active_statuses(user=None):
     statuses = set()
 
     for phase_name, phase in PHASES: