Avoid type-checking

opentech/apply/determinations/forms.py

@@ -94,12 +94,8 @@ class BaseDeterminationForm(forms.ModelForm):
         for key, value in choices:
             suffix = DETERMINATION_TRANSITION_SUFFIX[key]
             for transition_name in phase.transitions:
-                if type(suffix) is list:
-                    for item in suffix:
-                        if item in transition_name:
-                            available_choices.add((key, value))
-                else:
-                    if suffix in transition_name:
+                for item in suffix:
+                    if item in transition_name:
                         available_choices.add((key, value))
 
         self.fields['outcome'].choices = available_choices

opentech/apply/determinations/models.py

@@ -25,8 +25,8 @@ DETERMINATION_CHOICES = (
 
 DETERMINATION_TRANSITION_SUFFIX = {
     ACCEPTED: ['accepted', 'invited_to_proposal'],
-    REJECTED: 'rejected',
-    NEEDS_MORE_INFO: 'more_info',
+    REJECTED: ['rejected'],
+    NEEDS_MORE_INFO: ['more_info'],
 }
 
 

opentech/apply/determinations/views.py

@@ -93,12 +93,8 @@ class DeterminationCreateOrUpdateView(CreateOrUpdateView):
         suffix = DETERMINATION_TRANSITION_SUFFIX[determination]
 
         for transition_name in self.submission.phase.transitions:
-            if type(suffix) is list:
-                for item in suffix:
-                    if item in transition_name:
-                        return transition_name
-            else:
-                if suffix in transition_name:
+            for item in suffix:
+                if item in transition_name:
                     return transition_name