#962 move opinion check out of context and into template for all reviews page

opentech/apply/review/templates/review/includes/review_opinions_list.html

 {% load wagtailimages_tags %}
 
-<ul>
-{% for opinion in opinions %}
-    <li>
-        {{ opinion.author }}
-        {% if opinion.get_author_assignment %}{% image opinion.get_author_assignment.icon max-12x12 %}{% endif %}
-        {{ opinion.get_opinion_display }}s
-    </li>
-{% endfor %}
-</ul>
+{% if opinions %}
+	<ul>
+	{% for opinion in opinions %}
+	    <li>
+	        {{ opinion.author }}
+	        {% if opinion.get_author_assignment %}{% image opinion.get_author_assignment.icon max-12x12 %}{% endif %}
+	        {{ opinion.get_opinion_display }}s
+	    </li>
+	{% endfor %}
\ No newline at end of file
+	</ul>
+{% endif %}
\ No newline at end of file

opentech/apply/review/views.py

@@ -243,12 +243,9 @@ class ReviewListView(ListView):
 
         for i, review in enumerate(self.object_list):
             review_data['title']['answers'].append('<a href="{}">{}</a>'.format(review.get_absolute_url(), review.author))
-            if review.opinions:
-                opinions_template = get_template('review/includes/review_opinions_list.html')
-                opinions_html = opinions_template.render({'opinions': review.opinions.all()})
-                review_data['opinions']['answers'].append(opinions_html)
-            else:
-                review_data['opinions']['answers'].append("")
+            opinions_template = get_template('review/includes/review_opinions_list.html')
+            opinions_html = opinions_template.render({'opinions': review.opinions.select_related('author').all()})
+            review_data['opinions']['answers'].append(opinions_html)
             review_data['score']['answers'].append(str(review.get_score_display()))
             review_data['recommendation']['answers'].append(review.get_recommendation_display())
             review_data['comments']['answers'].append(review.get_comments_display(include_question=False))