Fix the test that was not returning an absolute URL

opentech/apply/funds/tests/test_views.py

@@ -223,7 +223,8 @@ class TestStaffSealedView(BaseSubmissionViewTestCase):
     def test_cant_post_to_sealed(self):
         submission = SealedSubmissionFactory()
         response = self.post_page(submission, {'some': 'data'}, 'sealed')
-        url = self.url_from_pattern('funds:submissions:sealed', kwargs={'pk': submission.id})
+        # Because of the redirect chain the url returned is not absolute
+        url = self.url_from_pattern('funds:submissions:sealed', kwargs={'pk': submission.id}, absolute=False)
         self.assertRedirects(response, url)
 
     def test_non_sealed_unaffected(self):

opentech/apply/utils/testing/tests.py

@@ -32,17 +32,14 @@ class BaseViewTestCase(TestCase):
 
     def url(self, instance, view_name=None, absolute=True):
         full_url_name = self.url_name.format(view_name or self.base_view_name)
-        url = reverse(full_url_name, kwargs=self.get_kwargs(instance))
-        if not absolute:
-            return url
+        return self.url_from_pattern(full_url_name, self.get_kwargs(instance), secure=True, absolute=absolute)
 
-        request = self.factory.get(url, secure=True)
-        return request.build_absolute_uri()
-
-    def url_from_pattern(self, pattern, kwargs=None):
+    def url_from_pattern(self, pattern, kwargs=None, secure=True, absolute=True):
         url = reverse(pattern, kwargs=kwargs)
-        request = self.factory.get(url, secure=True)
-        return request.build_absolute_uri()
+        request = self.factory.get(url, secure=secure)
+        if absolute:
+            return request.build_absolute_uri()
+        return request.path
 
     def get_page(self, instance=None, view_name=None):
         return self.client.get(self.url(instance, view_name), secure=True, follow=True)