Fixes to application previews and draft refactoring (#3795)
Fixes #3788 and a few other issues. The main problems being seen around the preview were when it came to the edit view. This was because the use of the `Draft` status was being relied on for the saving of content before previews, when realistically a new application revision had the same effect. Previously, Admins/Staff could submit new applications, but could not submit existing applications. This is why when an Admin had attempted to submit a preview or submit an edited application, they could not do so. This functionality has been moved from `ApplicantSubmissionEditView` to `BaseSubmissionEditView` as it made sense to me that Admins would be able to access the same edit workflow & transitions as Applicants. I believe most OTF staff avoid editing incoming applications though.
Showing
- hypha/apply/funds/migrations/0117_applicationrevision_is_draft.py 17 additions, 0 deletions...ply/funds/migrations/0117_applicationrevision_is_draft.py
- hypha/apply/funds/models/application_revisions.py 3 additions, 0 deletionshypha/apply/funds/models/application_revisions.py
- hypha/apply/funds/models/applications.py 18 additions, 9 deletionshypha/apply/funds/models/applications.py
- hypha/apply/funds/models/submissions.py 57 additions, 15 deletionshypha/apply/funds/models/submissions.py
- hypha/apply/funds/templates/funds/application_base.html 1 addition, 2 deletionshypha/apply/funds/templates/funds/application_base.html
- hypha/apply/funds/templates/funds/application_preview.html 8 additions, 3 deletionshypha/apply/funds/templates/funds/application_preview.html
- hypha/apply/funds/templates/funds/applicationrevision_list.html 3 additions, 0 deletions...apply/funds/templates/funds/applicationrevision_list.html
- hypha/apply/funds/tests/test_models.py 0 additions, 4 deletionshypha/apply/funds/tests/test_models.py
- hypha/apply/funds/tests/test_views.py 14 additions, 2 deletionshypha/apply/funds/tests/test_views.py
- hypha/apply/funds/views.py 162 additions, 101 deletionshypha/apply/funds/views.py
- hypha/settings/base.py 1 addition, 2 deletionshypha/settings/base.py
- hypha/static_src/sass/components/_revision.scss 2 additions, 1 deletionhypha/static_src/sass/components/_revision.scss
Loading
Please register or sign in to comment