Skip to content
Snippets Groups Projects
Commit 34b6a712 authored by Frank Duncan's avatar Frank Duncan
Browse files

Remove None reviewers from validation

This was caused by an issue where the "---" (None) reviewers were
causing the validation to fail, meaning that you had to fill out n-1
reviewers in the submission page in order for the save to go through.

The solution was to only check for duplicates with reviewers that were
selected.

Issue ots/clients/smex/hypha-tracker#2: Can't assign Staff
as reviewers of applications
parent 97dac1fc
No related branches found
No related tags found
No related merge requests found
......@@ -300,7 +300,7 @@ class UpdateReviewersForm(ApplicationSubmissionModelForm):
role_reviewers = [
user
for field, user in self.cleaned_data.items()
if field in self.role_fields
if field in self.role_fields and user
]
for field, role in self.role_fields.items():
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment