Merge pull request #472 from OpenTechFund/bugfix/ensure-logging

Make sure we actually call the logger

opentech/public/mailchimp/tests.py

@@ -50,8 +50,8 @@ class TestNewsletterView(TestCase):
         MAILCHIMP_LIST_ID='12345'
     )
     @responses.activate
-    @mock.patch('opentech.public.mailchimp.views.logging')
-    def test_error_with_mailchimp(self, logging):
+    @mock.patch('opentech.public.mailchimp.views.logger')
+    def test_error_with_mailchimp(self, logger):
         # Copied from the mailchimp playground
         response_data = {
             "title": "Invalid Resource",
@@ -66,4 +66,4 @@ class TestNewsletterView(TestCase):
         messages = list(response.context['messages'])
         self.assertEqual(len(messages), 1)
         self.assertIn('problem', str(messages[0]))
-        logging.info.assert_called_once_with(response_data)
+        logger.error.assert_called_once_with(response_data)

opentech/public/mailchimp/views.py

@@ -13,7 +13,7 @@ from mailchimp3 import MailChimp
 
 from .forms import NewsletterForm
 
-logging.getLogger('opentech')
+logger = logging.getLogger(__name__)
 
 
 @method_decorator(csrf_exempt, name='dispatch')
@@ -70,7 +70,7 @@ class MailchimpSubscribeView(FormMixin, RedirectView):
 
     def warning(self, e):
         messages.warning(self.request, _('Sorry, there has been an problem. Please try again later.'))
-        logging.info(e.args[0])
+        logger.error(e.args[0])
 
     def success(self):
         messages.success(self.request, _('Thank you for subscribing'))