Allow partners to view submission detail for which they are added as partner

opentech/apply/funds/views.py

@@ -328,6 +328,11 @@ class AdminSubmissionDetailView(ReviewContextMixin, ActivityContextMixin, Delega
 
     def dispatch(self, request, *args, **kwargs):
         submission = self.get_object()
+        # Only allow partners in the submission they are added as partners
+        if request.user.is_partner:
+            partner_has_access = submission.partners.filter(pk=request.user.pk).exists()
+            if not partner_has_access:
+                raise PermissionDenied
         redirect = SubmissionSealedView.should_redirect(request, submission)
         return redirect or super().dispatch(request, *args, **kwargs)
 

opentech/apply/users/models.py

@@ -103,7 +103,7 @@ class User(AbstractUser):
 
     @cached_property
     def is_applicant(self):
-        return not self.is_apply_staff and not self.is_reviewer
+        return not self.is_apply_staff and not self.is_reviewer and not self.is_partner
 
     class Meta:
         ordering = ('full_name', 'email')