GH-962 rename get_author_role method to get_author_assignment

opentech/apply/review/models.py

@@ -189,5 +189,5 @@ class ReviewOpinion(models.Model):
         return self.get_opinion_display()
 
     def get_author_role(self):
-        role = self.review.submission.assigned.with_roles().filter(reviewer=self.author).first()
-        return role.role if role else None
+        assignment = self.review.submission.assigned.with_roles().filter(reviewer=self.author).first()
+        return assignment.role if assignment else None

opentech/apply/review/templates/review/includes/review_opinions_list.html

@@ -4,7 +4,7 @@
 {% for opinion in opinions %}
     <li>
         {{ opinion.author }}
-        {% if opinion.get_author_role %}{% image opinion.get_author_role.icon max-12x12 %}{% endif %}
+        {% if opinion.get_author_assignment %}{% image opinion.get_author_assignment.icon max-12x12 %}{% endif %}
         {{ opinion.get_opinion_display }}s
     </li>
 {% endfor %}