Skip to content
Snippets Groups Projects
  1. Jan 12, 2015
  2. Jan 08, 2015
  3. Dec 24, 2014
  4. Sep 21, 2014
  5. Jul 29, 2014
    • Marc Cornellà's avatar
      Fix pass zsh completion and autoloading · 5a6df91e
      Marc Cornellà authored
      When autocompleting from `pass <TAB>', sometimes the following errors
      appear:
      
        _values:compvalues:10: not enough arguments
        find: `/home/user/.password-store': No such file or directory
        _values:compvalues:10: not enough arguments
        find: `/home/user/.password-store': No such file or directory
      
      The `_values' error happens when there is no password-store folder *or*
      there are no passwords in pass; the `find' error only when there is no
      password-store folder.
      
      We can trace it back to line 108, which contains the only `_values'
      statement that is executed when we autocomplete from pass. We confirm
      this by following the trail of execution, which is
      
        _pass -> _pass_cmd_show -> _pass_complete_entries ->
              -> _pass_complete_entries_helper
      
      If we try running the command inside `$()' on line 104, we see that it
      returns nothing and the output is blank. This means that `_values' only
      receives 1 of its 2 mandatory parameters, therefore the above error is
      triggered (not enough arguments).
      
      That is unless we don't have a password-store folder, in which case the
      `find: [...] no such file or directory' error is *also* triggered.
      
      We solve the first error by supplying a default value of "" if the
      command outputs nothing, using the zsh construct ${var:-else}.
      
      We solve the second error by redirecting the find command's stderr output
      to /dev/null, so the error is effectively suppressed.
      
      * * * *
      
      This patch also fixes the first tab completion, which currently only
      loads the completion function definition.
      
      We do this by adding a `_pass' statement at the end of the file, which
      runs the `_pass' completion function after loading its definition.
      This is the standard way an autoloaded function works; for other examples
      look at zsh's official completion files.
      5a6df91e
  6. Jul 24, 2014
  7. Jul 17, 2014
  8. Jul 08, 2014
  9. Jul 01, 2014
  10. Jun 30, 2014
  11. Jun 29, 2014
  12. Jun 28, 2014
    • Jason A. Donenfeld's avatar
      Allow options in EDITOR variable · 9ed79aac
      Jason A. Donenfeld authored
      This is required by most graphical editors, as the shell command they
      provide needs to be told to wait until the file has been closed.
      
      This reverts '311c98c9'. We thus use
      PATH so that the tests still pass in directories with spaces.
      9ed79aac
    • Andrew Spiers's avatar
      keepassx2pass: Substitute empty string for None · 4d53be77
      Andrew Spiers authored
      If keepassx2pass.py is given an xml file containing passwords with an empty
      title, like <title></title>, ElementTree.text returns None. This commit
      substitutes an empty string; which will produce a password with name '_',
      instead of raising AtttributeError, as shown in this exception::
      
          Traceback (most recent call last):
            File "contrib/importers/keepassx2pass.py", line 80, in <module>
              main(sys.argv[1])
            File "contrib/importers/keepassx2pass.py", line 77, in main
              import_group(group)
            File "contrib/importers/keepassx2pass.py", line 71, in import_group
              import_entry(entry, npath)
            File "contrib/importers/keepassx2pass.py", line 58, in import_entry
              print "Importing " + path_for(element, path)
            File "contrib/importers/keepassx2pass.py", line 37, in path_for
              title = cleanTitle(space_to_camelcase(element.find('title').text))
            File "contrib/importers/keepassx2pass.py", line 16, in space_to_camelcase
              for word in value.split(" "):
          AttributeError: 'NoneType' object has no attribute 'split'
      4d53be77
  13. Jun 16, 2014
  14. May 27, 2014
  15. May 14, 2014
  16. May 13, 2014
  17. May 10, 2014
  18. May 08, 2014
Loading