Skip to content
Snippets Groups Projects
  1. Apr 20, 2014
  2. Apr 19, 2014
  3. Apr 18, 2014
  4. Apr 17, 2014
  5. Apr 16, 2014
  6. Apr 15, 2014
  7. Apr 14, 2014
  8. Apr 12, 2014
    • Jason A. Donenfeld's avatar
      Use pipefail and randomize intermediate encrypted. · 2eaca825
      Jason A. Donenfeld authored
      
      Matthew writes:
      
          If the initial decrypt fails then the rest of the line shouldn't
          continue, as it won't be a properly decrypted password being
          re-encrypted and written over the existing passfile.
      
          One solution to this would be to enable pipefail (set -o pipefail) -
          either just before, or at the start of this script.  This would
          cause the failure of any of the commands in a pipe to set the return
          status of the whole pipeline to non-zero (the last failed command's
          return code is used).
      
      We take his suggestion with this patch. While we're at it, we take a
      little bit extra care (though not too much extra care) to select a more
      random intermediate password, in case folks have a strange habit of
      using a dot-new extension on files.
      
      Suggested-by: default avatarMatthew Richardson <m.richardson@ed.ac.uk>
      Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
  9. Apr 07, 2014
  10. Apr 06, 2014
  11. Apr 05, 2014
Loading