Skip to content

Don’t disable primary filters when sidebar is open

Justin Reese requested to merge 245-dont-disable-primary-filters into main

Prior to this change, when the user opened the All Filters sidebar, we disabled the primary filters atop the table. I think we originally did this out of concern that a user might conceptually be confused by the presence of some filters in both places — or perhaps it was concern that the state management would be too hairy.

However, it actually seems to confuse people more to have have the buttons conditionally disabled, while testing shows the state is kept in sync between the two places without a problem.

This MR removes that disabling feature.

Testing:

  1. In main Explore, open the All Filters sidebar
  2. ❌ The filter buttons in the primary filters section (atop the table) disable
  3. Switch to this branch and repeat
  4. ✅ The filter buttons remain enabled/usable

Closes https://code.librehq.com/ots/clients/lfc/torque-tracker/-/issues/245

Edited by Justin Reese

Merge request reports