PickSome is erroring on certain titles
Created by: slifty
We were facing an issue where an end user was reporting 500 errors from the server when logging in.
After some investigation I was able to reproduce a 500 error by:
- activating the PickSome tool (clicking "Start Selecting")
- Viewing a non-proposal page.
Since the main page after logging in is not a proposal page, this meant that for an end user it would appear that simply logging in would not work.
The error in apache2/error.log
was:
[Fri Jul 09 21:28:56.103866 2021] [php7:error] [pid 12439] [client 71.185.65.82:51212] PHP Fatal error: Uncaught TypeError: Argument 1 passed to Title::equals() must implement interface MediaWiki\Linker\LinkTarget, null given, called in /home/deploy/RacialEquity2030/mediawiki-1.35.0/torque-sites-config/picksome.php on line 33 and defined in /home/deploy/RacialEquity2030/mediawiki-1.35.0/includes/Title.php:3974
I dug in a bit and was able to reproduce in dev environment (after copying the latest TorqueConfig:ValidProposals
).
Let's smoosh the bug!