GitLab

The benefit of this setting was largely lost due to wfDebug() having
been replaced with calls to Logger->debug() for much of our code.

This is motivated by making ResourcLoader debug=2 able to make
its concurrent load.php requests more quickly during local dev.

This effectively reverts T49960. I was wrong there, thinking that
this variable has no reason for being. The vast majority of the time,
these aren't of interest on subresource requests. It's trivial
to enable when wanted, and any non-debug level messages still come
through either way, including PHP runtime errors, exceptions,
warnings, etc.

This seems to make load.php about 50% faster for local development
when using mediawiki-docker.
I used `ab` to perform a load.php request 300 times. The mean was
320-360ms before this patch (with and without DebugRawPage=false),
and around 120-140ms with patch (with DebugRawPage=false, default).

Bug: T85805
Bug: T225730
Change-Id: I061419adebf43e83cd0103bdb9b7a3296a2a1122

Title::getRootTitle will throw on invalid page titles. This can happen
when the page title contains a prefix that clashes with a registered
namespace or interwiki. For example when pages exist on a wiki, and
then the namespace or interwiki is registerered. These are meant to
be converted by maintenance/namespaceDupes.php.

The invalid page title could be viewed via curid= parameter.

In such situation, there is no way to re-create the Title object for
the given namespace and title. The only place where this happens during
a pageview is when the skin is trying to create a Title object for
the parent title (which is a shorter text of the otherwise mostly the
same title in the same namespace).

Workaround this by creating the string directly via the TitleFormatter
instead of creating the impossible Title object in the middle.

Bug: T290194
Change-Id: I946508ab7f95e391e0b71e1a3f0c81dcf12f73ee

This is used only in SMW Signup. Should be removed in next release.

Change-Id: Ic55a441effbeec07ffebee3aa725e35735473d9b

This allows the API to consistently return the new value for old rows.

Bug: T241709
Follow-Up: I36f49dc83718cc78f17fc340e6445030b8fd0c66
Change-Id: Ida69980f62a6ef070ba41b7e826967f424881716

Searching for "Special:EditPage/Mai" shows "Main Page" for example.

This effects the following special pages:
Special:DeletePage
Special:EditPage
Special:NewSection
Special:PageHistory
Special:PageInfo
Special:ProtectPage
Special:Purge

Change-Id: I2bfd7c42e258d4d296aff0912d685df4c65ea243

MWGrants is deprecated and should be replaced with the GrantsInfo and
the GrantsLocalization services.

Bug: T253077
Change-Id: I3cbf568b6de654acb6b06b4ab5d9d97a09f78ece

To do so, we move the relevant parts to a separate include file that's
included both by Setup and the test.

The --color-moved option is highly recommended when reviewing this patch
to verify correctness.

More tests to come.

Bug: T305093
Change-Id: I931b92357ec48db4665891c8546f86264885e881

The new class, UrlUtils, is usable standalone or as a service. Using it
as a service will just automatically load a few settings from site
configuration.

In addition to just making our code cleaner, this will enable making
some of Setup.php's dynamic configuration more sane.

Test coverage is all lines except invalid URLs -- I couldn't find any.

Bug: T305093
Change-Id: I706ef8a50aafb518e13222719575d274c3583b90

Change-Id: I8ed80ee4078b730eda34f7547dfa85ca7b135ff6

Use @phan-var annotation instead of multiple suppressions

Change-Id: Ieb49c3c7838f8ef638c9215c0ae04d7e1048b3cd

* Indicate whether a class is a service (to be found via MediaWikiServices)
  or a lower-level class for certain backend logic.

* Indicate how to create / where to get instances of non-service classes,
  e.g. point to the relevant service.

* Remove copy-pasta text in file docblock that is unrelated,
  and incorporate any relevant text into the class docblock instead.

Change-Id: Ia3b9b8c22da4d7160c5e14ae6a6a7c9dca30e9db

BundleSizeTest is mainly used by skins to test the size of the modules
of the skin. Using default skin may cause unexpected results.

Bug: T305779
Change-Id: Id77c6124c9b1fd20633cda47bbca89f9b6724a63

The wfDeprecated is called directly from __get/__set/__isset which needs
only a 2, not 3. That means the message is one caller of.

Change-Id: Ia29fb0a07841f69a4d8b95431f0915df9793c340

This avoids needless warnings in the error log.

Bug: T304960
Change-Id: I4b5747147eb0e0c428ee6a076933efe82b401c7b

They were last used in ab9ecc02

Bug: T224429
Change-Id: Id94329f03bb063a3c197b6091dfb35a430c24e90

Change-Id: Ia9d94eec51410be50bcd9e80692f626afd0bf322

Change-Id: I68ff2e8a29c7d1b0a48b94c557ca660ec29f78c6

Follow-Up: I08f14f712479e1b170c606e2b64857f8386acd76
Change-Id: I63b6f484bf498a9bbe574eaac66f89b4e045c0e2

Some permissions will now be checked twice, but we need to double
check whether the user is blocked on the associated talk page.

Bug: T305680
Change-Id: I02bfbc41a5ab05517acfe58c7c176961436d3ad9