From fca360ee8327d481f824d853edb360b9afdead52 Mon Sep 17 00:00:00 2001
From: Fredrik Jonsson <frjo@xdeb.org>
Date: Tue, 5 Feb 2019 15:45:04 +0100
Subject: [PATCH] Remove staff Slack notifications and staff e-mails for
READY_FOR_REVIEW.
---
opentech/apply/activity/messaging.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/opentech/apply/activity/messaging.py b/opentech/apply/activity/messaging.py
index 8b526980c..631870c2b 100644
--- a/opentech/apply/activity/messaging.py
+++ b/opentech/apply/activity/messaging.py
@@ -329,7 +329,7 @@ class SlackAdapter(AdapterBase):
reviewers_to_notify.append(reviewer)
reviewers = ', '.join(
- self.slack_id(reviewer) or str(reviewer) for reviewer in reviewers_to_notify
+ str(reviewer) for reviewer in reviewers_to_notify
)
return (
@@ -439,7 +439,7 @@ class EmailAdapter(AdapterBase):
return [
reviewer.email
for reviewer in submission.missing_reviewers.all()
- if submission.phase.permissions.can_review(reviewer)
+ if submission.phase.permissions.can_review(reviewer) and not reviewer.is_apply_staff
]
def render_message(self, template, **kwargs):
--
GitLab