From fc5406e78fbe91705a3f2347857476e37640bef5 Mon Sep 17 00:00:00 2001 From: Tomasz Knapik <hi@tmkn.org> Date: Tue, 15 Jan 2019 12:13:43 +0000 Subject: [PATCH] Fix minor mistakes --- opentech/static_src/src/app/src/redux/actions/submissions.js | 1 + opentech/static_src/src/app/src/redux/selectors/submissions.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/opentech/static_src/src/app/src/redux/actions/submissions.js b/opentech/static_src/src/app/src/redux/actions/submissions.js index b2e5ad27a..4090ab47e 100644 --- a/opentech/static_src/src/app/src/redux/actions/submissions.js +++ b/opentech/static_src/src/app/src/redux/actions/submissions.js @@ -21,6 +21,7 @@ export const fetchSubmissionsByRound = roundId => { const json = await response.json(); if (!response.ok) { dispatch(failLoadingSubmissionsByRound(roundId)); + return; } dispatch(updateSubmissionsByRound(roundId, json)); } catch (e) { diff --git a/opentech/static_src/src/app/src/redux/selectors/submissions.js b/opentech/static_src/src/app/src/redux/selectors/submissions.js index 5a995e997..fa17eda2f 100644 --- a/opentech/static_src/src/app/src/redux/selectors/submissions.js +++ b/opentech/static_src/src/app/src/redux/selectors/submissions.js @@ -17,7 +17,7 @@ const getCurrentRoundSubmissionsByStatus = createSelector( if (!(submission.status in submissionsByStatus)) { submissionsByStatus[submission.status] = []; } - submissionsByStatus[submission.status].push(submission); + submissionsByStatus[submission.status].push({ ...submission }); } const formattedSubmissionsByStatus = []; for (const [submissionStatus, statusSubmissions] of Object.entries(submissionsByStatus)) { -- GitLab