From f9cddde06e5cbc67701be1066f0910801815dc39 Mon Sep 17 00:00:00 2001
From: Erin Mullaney <erin.mullaney@torchbox.com>
Date: Wed, 13 Feb 2019 08:15:06 -0500
Subject: [PATCH] #957 form fix and test adjustment
---
opentech/apply/funds/forms.py | 3 +--
opentech/apply/funds/tests/test_views.py | 3 ++-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/opentech/apply/funds/forms.py b/opentech/apply/funds/forms.py
index 28a3ba59d..ee2d2e838 100644
--- a/opentech/apply/funds/forms.py
+++ b/opentech/apply/funds/forms.py
@@ -186,8 +186,7 @@ class UpdateReviewersForm(forms.ModelForm):
role=None,
reviewer=existing_reviewer,
)
- existing.first().reviewer = reviewer
- existing.first().save()
+ existing.update(reviewer=reviewer)
else:
AssignedReviewers.objects.create(
submission=instance,
diff --git a/opentech/apply/funds/tests/test_views.py b/opentech/apply/funds/tests/test_views.py
index 745aab5ce..d107451b8 100644
--- a/opentech/apply/funds/tests/test_views.py
+++ b/opentech/apply/funds/tests/test_views.py
@@ -230,9 +230,10 @@ class TestReviewersUpdateView(BaseSubmissionViewTestCase):
AssignedWithRoleReviewersFactory(role=self.roles[0], submission=submission, reviewer=self.staff[0])
self.assertCountEqual(submission.reviewers.all(), [self.staff[0]])
- self.post_form(submission, [self.staff[1]])
+ self.post_form(submission, reviewer_roles=[self.staff[1]])
self.assertCountEqual(submission.reviewers.all(), [self.staff[1]])
+ self.assertEqual(submission.assigned.with_roles().first().reviewer, self.staff[1])
def test_lead_cant_add_reviewers_single(self):
submission = ApplicationSubmissionFactory(lead=self.user)
--
GitLab