From ed2dc3717dfd3bf847471d63e780613016889b6b Mon Sep 17 00:00:00 2001
From: Saurabh Kumar <theskumar@users.noreply.github.com>
Date: Fri, 12 Apr 2024 16:28:21 +0800
Subject: [PATCH] Fix beta submission view dropdown for long list, make them
scroll (#3860)
Fixes https://github.com/HyphaApp/hypha/issues/3853
Adds a max-height and overscoll to the dropdown items
---
.../funds/templates/submissions/submenu/bulk-update-lead.html | 2 +-
hypha/apply/funds/templates/submissions/submenu/category.html | 2 +-
.../funds/templates/submissions/submenu/change-status.html | 2 +-
hypha/apply/funds/templates/submissions/submenu/funds.html | 2 +-
hypha/apply/funds/templates/submissions/submenu/leads.html | 2 +-
hypha/apply/funds/templates/submissions/submenu/meta-terms.html | 2 +-
hypha/apply/funds/templates/submissions/submenu/reviewers.html | 2 +-
7 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/hypha/apply/funds/templates/submissions/submenu/bulk-update-lead.html b/hypha/apply/funds/templates/submissions/submenu/bulk-update-lead.html
index 21b4826b2..97e81f662 100644
--- a/hypha/apply/funds/templates/submissions/submenu/bulk-update-lead.html
+++ b/hypha/apply/funds/templates/submissions/submenu/bulk-update-lead.html
@@ -1,6 +1,6 @@
{% load i18n %}
{% load querystrings %}
-<ul class="text-gray-700 divide-y" aria-labelledby="dropdown-change-status" data-filter-list>
+<ul class="text-gray-700 divide-y max-h-80 overflow-scroll" aria-labelledby="dropdown-change-status" data-filter-list>
{% for user in leads %}
<li data-filter-item-text>
<a
diff --git a/hypha/apply/funds/templates/submissions/submenu/category.html b/hypha/apply/funds/templates/submissions/submenu/category.html
index ece63a3a8..4835568d8 100644
--- a/hypha/apply/funds/templates/submissions/submenu/category.html
+++ b/hypha/apply/funds/templates/submissions/submenu/category.html
@@ -1,6 +1,6 @@
{% load i18n %}
{% load querystrings %}
-<ul class="text-gray-700 dark:text-gray-200" aria-labelledby="dropdown-categories"
+<ul class="text-gray-700 max-h-80 overflow-scroll" aria-labelledby="dropdown-categories"
data-filter-list>
{% if selected_category_options %}
<li data-filter-item-text>
diff --git a/hypha/apply/funds/templates/submissions/submenu/change-status.html b/hypha/apply/funds/templates/submissions/submenu/change-status.html
index c31cbeeb3..c7eb927e0 100644
--- a/hypha/apply/funds/templates/submissions/submenu/change-status.html
+++ b/hypha/apply/funds/templates/submissions/submenu/change-status.html
@@ -1,6 +1,6 @@
{% load i18n %}
{% load querystrings %}
-<ul class="text-gray-700 divide-y" aria-labelledby="dropdown-change-status">
+<ul class="text-gray-700 divide-y max-h-80 overflow-scroll" aria-labelledby="dropdown-change-status">
{% for slug, value in statuses %}
<li data-filter-for="change-status-filter-field">
<a
diff --git a/hypha/apply/funds/templates/submissions/submenu/funds.html b/hypha/apply/funds/templates/submissions/submenu/funds.html
index d45cf21ea..954cd9391 100644
--- a/hypha/apply/funds/templates/submissions/submenu/funds.html
+++ b/hypha/apply/funds/templates/submissions/submenu/funds.html
@@ -1,7 +1,7 @@
{% load i18n %}
{% load querystrings heroicons %}
-<ul class="text-gray-700 divide-y" aria-labelledby="dropdownBgHoverButton" data-filter-list>
+<ul class="text-gray-700 divide-y max-h-80 overflow-scroll" aria-labelledby="dropdownBgHoverButton" data-filter-list>
{% if selected_funds %}
<li data-filter-item-text>
<a href="{% url "apply:submissions:list-alt" %}{% remove_from_query "only_query_string" "page" "fund" %}"
diff --git a/hypha/apply/funds/templates/submissions/submenu/leads.html b/hypha/apply/funds/templates/submissions/submenu/leads.html
index 0280d951d..6e2ccbb4e 100644
--- a/hypha/apply/funds/templates/submissions/submenu/leads.html
+++ b/hypha/apply/funds/templates/submissions/submenu/leads.html
@@ -1,6 +1,6 @@
{% load i18n %}
{% load querystrings heroicons %}
-<ul class="text-gray-700 divide-y" aria-labelledby="dropdownBgHoverButton" data-filter-list>
+<ul class="text-gray-700 divide-y max-h-80 overflow-scroll" aria-labelledby="dropdownBgHoverButton" data-filter-list>
{% if selected_leads %}
<li data-filter-item-text>
<a href="{% url "apply:submissions:list-alt" %}{% remove_from_query "only_query_string" "page" "lead" %}"
diff --git a/hypha/apply/funds/templates/submissions/submenu/meta-terms.html b/hypha/apply/funds/templates/submissions/submenu/meta-terms.html
index 5d1294d82..7eed965d0 100644
--- a/hypha/apply/funds/templates/submissions/submenu/meta-terms.html
+++ b/hypha/apply/funds/templates/submissions/submenu/meta-terms.html
@@ -1,6 +1,6 @@
{% load i18n %}
{% load querystrings %}
-<ul class="text-gray-700 divide-y" aria-labelledby="dropdown-meta-terms" data-filter-list>
+<ul class="text-gray-700 divide-y max-h-80 overflow-scroll" aria-labelledby="dropdown-meta-terms" data-filter-list>
{% if selected_meta_terms %}
<li data-filter-item-text>
<a href="{% url "apply:submissions:list-alt" %}{% remove_from_query "only_query_string" "page" "meta_terms" %}"
diff --git a/hypha/apply/funds/templates/submissions/submenu/reviewers.html b/hypha/apply/funds/templates/submissions/submenu/reviewers.html
index a64d1b980..ed9ee3e53 100644
--- a/hypha/apply/funds/templates/submissions/submenu/reviewers.html
+++ b/hypha/apply/funds/templates/submissions/submenu/reviewers.html
@@ -1,6 +1,6 @@
{% load i18n %}
{% load querystrings %}
-<ul class="text-gray-700 divide-y dark:text-gray-200" aria-labelledby="dropdown-reviewers" data-filter-list>
+<ul class="text-gray-700 divide-y max-h-80 overflow-scroll" aria-labelledby="dropdown-reviewers" data-filter-list>
{% if selected_reviewers %}
<li data-filter-item-text>
<a href="{% url "apply:submissions:list-alt" %}{% remove_from_query "only_query_string" "page" "reviewers" %}"
--
GitLab