From eb8f0bd2c96108fe82a26b7d31f2105777acb37e Mon Sep 17 00:00:00 2001
From: Todd Dembrey <todd.dembrey@torchbox.com>
Date: Tue, 19 Feb 2019 16:49:29 +0000
Subject: [PATCH] GH-858: Add tests to cover posting data
---
.../funds/tests/views/test_batch_progress.py | 110 ++++++++++++++++++
opentech/apply/utils/views.py | 5 +-
2 files changed, 114 insertions(+), 1 deletion(-)
create mode 100644 opentech/apply/funds/tests/views/test_batch_progress.py
diff --git a/opentech/apply/funds/tests/views/test_batch_progress.py b/opentech/apply/funds/tests/views/test_batch_progress.py
new file mode 100644
index 000000000..4d18a380f
--- /dev/null
+++ b/opentech/apply/funds/tests/views/test_batch_progress.py
@@ -0,0 +1,110 @@
+from unittest import mock
+
+from opentech.apply.funds.models import ApplicationSubmission
+
+from opentech.apply.funds.tests.factories import (
+ ApplicationSubmissionFactory,
+ InvitedToProposalFactory,
+)
+from opentech.apply.users.tests.factories import (
+ ReviewerFactory,
+ StaffFactory,
+ UserFactory,
+)
+from opentech.apply.utils.testing.tests import BaseViewTestCase
+
+
+class BaseBatchProgressViewTestCase(BaseViewTestCase):
+ url_name = 'funds:submissions:{}'
+ base_view_name = 'list'
+
+ def data(self, action, submissions):
+ return {
+ 'form-submitted-batch_progress_form': 'Update',
+ 'action': action,
+ 'submissions': ','.join([str(submission.id) for submission in submissions]),
+ }
+
+
+class StaffTestCase(BaseBatchProgressViewTestCase):
+ user_factory = StaffFactory
+
+ def test_can_progress_application(self):
+ submission = ApplicationSubmissionFactory()
+ action = 'open-review'
+ self.post_page(data=self.data(action, [submission]))
+ submission = self.refresh(submission)
+ self.assertEqual(submission.status, 'internal_review')
+
+ def test_can_progress_multiple_applications(self):
+ submissions = ApplicationSubmissionFactory.create_batch(3)
+ action = 'open-review'
+ self.post_page(data=self.data(action, submissions))
+
+ self.assertCountEqual(
+ [self.refresh(submission).status for submission in submissions],
+ ['internal_review'] * 3,
+ )
+
+ def test_cant_progress_in_incorrect_state(self):
+ submission = ApplicationSubmissionFactory()
+ action = 'close-review'
+ self.post_page(data=self.data(action, [submission]))
+ submission = self.refresh(submission)
+ self.assertEqual(submission.status, 'in_discussion')
+
+ def test_can_progress_one_in_mixed_state(self):
+ bad_submission = ApplicationSubmissionFactory()
+ good_submission = ApplicationSubmissionFactory(status='internal_review')
+ action = 'close-review'
+ self.post_page(data=self.data(action, [good_submission, bad_submission]))
+ good_submission = self.refresh(good_submission)
+ bad_submission = self.refresh(bad_submission)
+ self.assertEqual(bad_submission.status, 'in_discussion')
+ self.assertEqual(good_submission.status, 'post_review_discussion')
+
+ def test_can_progress_different_states(self):
+ submission = ApplicationSubmissionFactory()
+ other_submission = InvitedToProposalFactory()
+ action = 'open-review'
+ self.post_page(data=self.data(action, [submission, other_submission]))
+ submission = self.refresh(submission)
+ other_submission = self.refresh(other_submission)
+ self.assertEqual(submission.status, 'internal_review')
+ self.assertEqual(other_submission.status, 'proposal_internal_review')
+
+ @mock.patch('opentech.apply.funds.views.messenger')
+ def test_messenger_not_called_with_failed(self, patched):
+ submission = ApplicationSubmissionFactory()
+ action = 'close-review'
+ self.post_page(data=self.data(action, [submission]))
+ patched.assert_called_once()
+ _, _, kwargs = patched.mock_calls[0]
+ self.assertQuerysetEqual(kwargs['submissions'], ApplicationSubmission.objects.none())
+
+ @mock.patch('opentech.apply.funds.views.messenger')
+ def test_messenger_with_submission_in_review(self, patched):
+ submission = ApplicationSubmissionFactory()
+ action = 'open-review'
+ self.post_page(data=self.data(action, [submission]))
+ self.assertEqual(patched.call_count, 2)
+ _, _, kwargs = patched.mock_calls[0]
+ self.assertCountEqual(kwargs['submissions'], [submission])
+ _, _, kwargs = patched.mock_calls[1]
+ self.assertCountEqual(kwargs['submissions'], [submission])
+
+
+class ReivewersTestCase(BaseBatchProgressViewTestCase):
+ user_factory = ReviewerFactory
+
+ def test_cant_post_to_page(self):
+ response = self.post_page()
+ self.assertEqual(response.status_code, 405)
+
+
+class ApplicantTestCase(BaseBatchProgressViewTestCase):
+ user_factory = UserFactory
+
+ def test_cant_access_page_to_page(self):
+ response = self.post_page()
+ self.assertEqual(response.status_code, 403)
diff --git a/opentech/apply/utils/views.py b/opentech/apply/utils/views.py
index d4924b0da..a8dfda0d3 100644
--- a/opentech/apply/utils/views.py
+++ b/opentech/apply/utils/views.py
@@ -1,5 +1,6 @@
from django.contrib.auth.decorators import login_required
from django.forms.models import ModelForm
+from django.http import HttpResponseForbidden
from django.utils.decorators import method_decorator
from django.views import defaults
from django.views.generic import View
@@ -34,7 +35,9 @@ class ViewDispatcher(View):
elif self.reviewer_check(request):
view = self.reviewer_view
- return view.as_view()(request, *args, **kwargs)
+ if view:
+ return view.as_view()(request, *args, **kwargs)
+ return HttpResponseForbidden()
class DelegatableBase(ContextMixin):
--
GitLab