From e91598eec2f4036d4680f76e25441f9793fb08dd Mon Sep 17 00:00:00 2001
From: Todd Dembrey <todd.dembrey@torchbox.com>
Date: Tue, 5 Mar 2019 12:01:14 +0000
Subject: [PATCH] GH-1016: Make sure the proptypes are aligned
---
opentech/static_src/src/app/src/components/ReviewBlock/index.js | 2 +-
opentech/static_src/src/app/src/containers/ReviewInformation.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/opentech/static_src/src/app/src/components/ReviewBlock/index.js b/opentech/static_src/src/app/src/components/ReviewBlock/index.js
index 05a1d9f8a..1a7270d3d 100644
--- a/opentech/static_src/src/app/src/components/ReviewBlock/index.js
+++ b/opentech/static_src/src/app/src/components/ReviewBlock/index.js
@@ -55,7 +55,7 @@ export const Review = ({ url, author, score, recommendation, children }) => {
Review.propTypes = {
author: PropTypes.string.isRequired,
- score: PropTypes.number.isRequired,
+ score: PropTypes.oneOfType([PropTypes.number, PropTypes.string]).isRequired,
recommendation: PropTypes.shape({
display: PropTypes.string.isRequired,
}).isRequired,
diff --git a/opentech/static_src/src/app/src/containers/ReviewInformation.js b/opentech/static_src/src/app/src/containers/ReviewInformation.js
index dc3bafb42..93628f57a 100644
--- a/opentech/static_src/src/app/src/containers/ReviewInformation.js
+++ b/opentech/static_src/src/app/src/containers/ReviewInformation.js
@@ -54,7 +54,7 @@ const ReviewInformation = ({ data }) => {
return <Review
key={reviewer.id}
- url={review.reviewUrl}
+ url={review.url}
author={reviewer.name}
score={review.score}
recommendation={review.recommendation} >
--
GitLab