From e09fbdf4ec936fea6f97e233d616933020ff4d2b Mon Sep 17 00:00:00 2001 From: Todd Dembrey <todd.dembrey@torchbox.com> Date: Tue, 19 Dec 2017 09:51:46 +0000 Subject: [PATCH] Fix the flake8 errors --- opentech/apply/tests/test_workflow.py | 1 + opentech/apply/views.py | 5 +---- opentech/apply/workflow.py | 8 ++++---- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/opentech/apply/tests/test_workflow.py b/opentech/apply/tests/test_workflow.py index 54b5caa6e..2186455e0 100644 --- a/opentech/apply/tests/test_workflow.py +++ b/opentech/apply/tests/test_workflow.py @@ -9,6 +9,7 @@ from .factories import ActionFactory, PhaseFactory, StageFactory, WorkflowFactor class TestWorkflowCreation(SimpleTestCase): def test_can_create_workflow(self): stage = StageFactory() + class NewWorkflow(Workflow): name = 'single_stage' stage_classes = [stage] diff --git a/opentech/apply/views.py b/opentech/apply/views.py index f5ec9072c..9e4e9a318 100644 --- a/opentech/apply/views.py +++ b/opentech/apply/views.py @@ -1,5 +1,4 @@ from django import forms -from django.shortcuts import render from django.template.response import TemplateResponse from .workflow import SingleStage, DoubleStage @@ -18,7 +17,7 @@ class BasicSubmissionForm(forms.Form): def demo_workflow(request, wf_id): wf = int(wf_id) - workflow_class = workflows[wf-1] + workflow_class = workflows[wf - 1] workflow = workflow_class([BasicSubmissionForm] * wf) current_phase = request.POST.get('current') @@ -59,5 +58,3 @@ def demo_workflow(request, wf_id): 'form': form, } return TemplateResponse(request, 'apply/demo_workflow.html', context) - - diff --git a/opentech/apply/workflow.py b/opentech/apply/workflow.py index 73655be0f..ff774fc82 100644 --- a/opentech/apply/workflow.py +++ b/opentech/apply/workflow.py @@ -45,7 +45,7 @@ class Workflow: for i, stage in enumerate(self.stages): if stage == current_stage: try: - return self.stages[i+1] + return self.stages[i + 1] except IndexError: pass @@ -69,7 +69,6 @@ class Workflow: return stage.next() return None - def __str__(self) -> str: return self.name @@ -112,17 +111,18 @@ class Stage: for i, phase in enumerate(self.phases): if phase == current_phase: try: - return self.phases[i+1] + return self.phases[i + 1] except IndexError: pass return None + class Phase: actions: Sequence['Action'] = list() name: str = '' public_name: str = '' - def __init__(self, name: str='', public_name:str = '') -> None: + def __init__(self, name: str='', public_name: str ='') -> None: if name: self.name = name -- GitLab